Page MenuHomePhabricator

Surfacing structured tasks: buttons in pop-up should be both neutral
Open, Needs TriagePublic

Description

Description

The Yes and No buttons shown on the pop-up use Progressive and a Neutral variants, respectively. We should be using Neutral for both of them so that we make it clear that we aren't emphasizing that the user should click on 'Yes' (especially since we don't know if the suggestion is correct).

Design

reading.mode.popup (12).png (3×1 px, 380 KB)

Acceptance criteria

  • Both 'Yes' and 'No' buttons on the popup use the Neutral variant.

Event Timeline

@Michael & @Sgs - Some recent design feedback came in that we shouldn't emphasize the "Yes" option if we don't know the suggestion is correct. Making both options neutral also better matches the UI within the VE pop-up.

I'm hoping this is a very simple update, but we can also delay this work if needed or if engineers think this change needs more discussion.

This should be a one-line change.

Change #1093934 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(surfacing): change "Yes"-button to look like the "No"-button

https://gerrit.wikimedia.org/r/1093934

Change #1093934 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(surfacing): change "Yes"-button to look like the "No"-button

https://gerrit.wikimedia.org/r/1093934

Change #1099682 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.5] fix(surfacing): change "Yes"-button to look like the "No"-button

https://gerrit.wikimedia.org/r/1099682

Change #1099682 abandoned by Michael Große:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.5] fix(surfacing): change "Yes"-button to look like the "No"-button

Reason:

Squashed into Ic1fa23a1eeaba34f74644ad222e50559d605a74c

https://gerrit.wikimedia.org/r/1099682