Page MenuHomePhabricator

Basic topic selection: Dialog header adjustment when adjusting suggestions
Open, Needs TriagePublic

Description

In T368422, an initial version was implemented to support basic topic selection in order to customize translation suggestions. The "Adjust suggestions view" provides a list of topics for users to select. This ticket focuses on the header that is part of that view, proposing two adjustments:

  • Make the header sticky. The list of topics can be long, and the header where the confirmation button will appear is no longer visible as users scroll. Making the header sticky will make the confirmation button visible as soon as the user selects a filter, without the need to scroll up. This requires to:
    • Add a bottom border to the header using the border-color-subtle Codex border token
    • Add additional padding at the top of the list of items to avoid the border to be too close. The space should be spacing-100 (16px) based on Codex spacing tokens.
    • Make the header element to stick to the top of the dialog as the user scrolls (staying on top of the contents).
  • Reduce space between close icon and title. Currently, there is a larger gap between the close button and the "Adjust suggestions" label. The space should be spacing-100 (16px) based on Codex spacing tokens.

The idea is to provide a similar style to the Codex Dialog component.

CurrentProposed
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&active-list.png (568×320 px, 45 KB)
bn.m.wikipedia.org_w_index.php_title=%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_%E0%A6%AC%E0%A6%BF%E0%A6%B7%E0%A6%AF%E0%A6%BC%E0%A6%AC%E0%A6%B8%E0%A7%8D%E0%A6%A4%E0%A7%81_%E0%A6%85%E0%A6%A8%E0%A7%81%E0%A6%AC%E0%A6%BE%E0%A6%A6&active- (2).png (568×320 px, 43 KB)

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.