Page MenuHomePhabricator

Support sections in the dropdown version of HtmlMultiSelectField
Closed, ResolvedPublic

Description

When 'dropdown' => true and the list of options is grouped into sections, HtmlMultiSelectField just outputs a list of checkboxes, and doesn't convert it to a dropdown. The Campaigns-Product-Team would like to use sections with a dropdown for T380200, so we should look into fixing this.

Event Timeline

Change #1098693 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Support sections in the dropdown version of HtmlMultiSelectField

https://gerrit.wikimedia.org/r/1098693

I wanted to do this a long time ago and have some WIP around, glad to help.

I wanted to do this a long time ago and have some WIP around, glad to help.

Thank you! We're now focused on finishing up work on T366765, but we should get to this soon -- hopefully next week.

Change #1098693 merged by jenkins-bot:

[mediawiki/core@master] Support sections in the dropdown mode of HtmlMultiSelectField

https://gerrit.wikimedia.org/r/1098693

Daimona added a subscriber: vaughnwalters.

@vaughnwalters I would suggest briefly testing that the multiselect widget works same as before. You can use the wiki field on Special:EnableEventRegistration or Special:AllEvents, whichever you prefer. A basic test should suffice. Note that this is a core change so you need to pull MW core. Thanks!

vaughnwalters claimed this task.

This is working as expected, marking as done / resolved.