TMH seems to have mixed tabs and space whitespace, and a lot of trailing whitespace
Can it be fixed up?
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz36654
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add php code sniffer | mediawiki/extensions/TimedMediaHandler | master | +939 -791 |
Event Timeline
Comment Actions
jgerber wrote:
whitespace is cleaned up, not sure how to find and replace mixed tabs and spaces
Comment Actions
I was working on the upstream repo for this a while ago:
https://github.com/hartman/mwEmbed/compare/jscleanup
I'm considering merging it into our tree instead.
Comment Actions
Should this be closed since php code sniffer is used to identify these problems and make the code look nice.
Comment Actions
@Paladox: A task should be closed if the problem in the task description has been fixed. So you should check that, report here, and decide.
Comment Actions
I think we can fix this. The remaining code style issues are in 'upstream' code. Even if we don't switch to VideoJS, I don't really think those issues should be part of this. Original reporter was Reedy, so that also sort of indicates that this most likely was about the php code.