Page MenuHomePhabricator

Fixup whitespace
Closed, ResolvedPublic


TMH seems to have mixed tabs and space whitespace, and a lot of trailing whitespace

Can it be fixed up?

Version: unspecified
Severity: normal


Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:22 AM
bzimport set Reference to bz36654.

jgerber wrote:

whitespace is cleaned up, not sure how to find and replace mixed tabs and spaces

Joyceg set Security to None.

I was working on the upstream repo for this a while ago:

I'm considering merging it into our tree instead.

Joyceg removed Joyceg as the assignee of this task.Mar 2 2015, 3:21 PM

Change 247294 had a related patch set uploaded (by Paladox):
Add php code sniffer

Change 247294 merged by jenkins-bot:
Add php code sniffer

Paladox removed a subscriber: gerritbot.

Should this be closed since php code sniffer is used to identify these problems and make the code look nice.

@Paladox: A task should be closed if the problem in the task description has been fixed. So you should check that, report here, and decide.

TheDJ claimed this task.

I think we can fix this. The remaining code style issues are in 'upstream' code. Even if we don't switch to VideoJS, I don't really think those issues should be part of this. Original reporter was Reedy, so that also sort of indicates that this most likely was about the php code.