Page MenuHomePhabricator

Full-text search in mobile site stopped working
Closed, ResolvedPublic

Description

Author: philinje

Description:
In the release on May 1, the deployment of full-screen search caused a regression whereby full-text search is no longer invoked when the user taps the Search button in the keyboard. It is possible the regression appeared earlier.


Version: unspecified
Severity: normal

Details

Reference
bz36679

Related Objects

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 12:23 AM
bzimport set Reference to bz36679.
bzimport added a subscriber: Unknown Object (MLST).

Currently tapping the search icon on the iphone keyboard or pressing enter causes the user to be navigated to the top result

This was introduced to address bug 35528 which this is in conflict with and is not a regression. We should decide on the best behaviour.

  • Bug 36690 has been marked as a duplicate of this bug. ***

Max points out options are

  • switch from action=opensearch to action=query&list=search for all searches
  • fire full text search on pressing enter/search button (note the search button is not visible when the search is full screen so would need to be enter)

So I've reverted the change in bug 35528 and made it so clicking search/pressing enter/ clicking search button fires a full text search

see https://gerrit.wikimedia.org/r/7172

On a separate note we might want to change the search suggestions to use a stronger search rather than the prefix search it currently does perform. This would be a slower query but would lead to more results.