Page MenuHomePhabricator

Unnecessary "<h2></h2>" tags created in Main page by MF extension
Closed, ResolvedPublic

Description

MobileFrontend extension adds unnecessary "<h2></h2>" tags when reformatting the Main page. The result is plenty of extra white in the mobile Main pages suffering this problems. It seems to be linked to <div> tags in the original source but I'm not sure.

Look this example, using the MF version from git master-0880467 (1012-05-15):

  • Wiki format in the edit form:

<div id="mf-intro" style="font-size:162%; border:none; margin:0; padding:.1em; color:#000;">[[Proyecto espiral|{{NUMBEROFARTICLES}} propuestas conectadas]]</div>
<div id="mf-intro-pie" style="top:+0.2em; font-size:95%;">para mejorar tu vida y tu entorno</div>

  • Rendered in mobile version:

<div id="mf-intro" style="font-size:162%; border:none; margin:0; padding:.1em; color:#000;"><a href="/wiki/Proyecto_espiral" title="Proyecto espiral" class="mw-redirect">196 propuestas conectadas</a></div>
<br clear="all">
<h2></h2>
<div id="mf-intro-pie" style="top:+0.2em; font-size:95%;">para mejorar tu vida y tu entorno</div>

("<br clear="all">" is also created next to the h2 but it is probably ok to have it and play safe)

The desktop version doesn't add anything between both <div>.


Version: unspecified
Severity: normal

Details

Reference
bz36893

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:27 AM
bzimport set Reference to bz36893.
bzimport added a subscriber: Unknown Object (MLST).

A bit of background in case you are not aware (as it is not obvious) -
currently title attributes are responsible for headings on the homepage. See
bug 32583 for more details. What's happening here is when no title attribute is
set an empty h2 is being printed

This is addressed in https://gerrit.wikimedia.org/r/7797

Yes! Tested with latest master branch & this works. Thank you for the fast response. Verifying.