Page MenuHomePhabricator

In the TranslationNotifications extension, if user is in bot group, mark edits as bot
Closed, ResolvedPublic

Description

Author: avocatomail

Description:
Although I granted bot flag to user:Translation Notification Bot in the Arabic Wikipedia (ar.wiki), it's edits still can be seen in RecentChanges in default mode which hides bots' edits. Please, solve this problem.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44210

Details

Reference
bz41637

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:02 AM
bzimport set Reference to bz41637.
bzimport created this task.Nov 1 2012, 3:11 PM

I've updated the summary, to better reflect the need I see in description.

I think this is a duplicate of bug 33461, or a dependency of it, like bug 25455.

  • This bug has been marked as a duplicate of bug 25455 ***

Sorry.

  • This bug has been marked as a duplicate of bug 33461 ***

Also, note that several projects made the account autopatrolled and *that* works, because patrol is not an edit flag, as Niklas noted on bug 38590.

I think we can apply bot=1 for edits via the WebAPI. It will just be ignored if it is not possible to set it.

Are there any downsides for making these edits as bot edits? Will users still get notifications about the edits?

(In reply to comment #5)

Will users still
get notifications about the edits?

Yes, if the edits are not marked minor too. (This may change in the future, it's not a well documented thing.)

(In reply to comment #5)

I think we can apply bot=1 for edits via the WebAPI. It will just be ignored
if it is not possible to set it.

Right. This is a one-line fix to TranslationNotificationJob.php, it looks like. Marking this bug with the "easy" keyword accordingly.

Related URL: https://gerrit.wikimedia.org/r/66372 (Gerrit Change I0fbe0646a7e611202cea921d422ba14598988045)

Related URL: https://gerrit.wikimedia.org/r/66374 (Gerrit Change I27e988d8a71b2f9d769d7d987a95705c20dd6414)

I don't know if this is really fixed. It just flooded Meta (and presumably several other wikis).

This is my fault. I'm uploading a new patchset in a few minutes which should actually fix the bug.

Change 73918 had a related patch set uploaded by Legoktm:
If the local user has the bot userright, mark the edit as bot.

https://gerrit.wikimedia.org/r/73918

Change 73918 merged by jenkins-bot:
If the local user has the bot userright, mark the edit as bot.

https://gerrit.wikimedia.org/r/73918

The patch affects more the original intentions of bug 44210 than of comment 0 (ar.wiki's case was already ok), anyway this is definitely fixed.

  • Bug 49323 has been marked as a duplicate of this bug. ***