Document Special:PermanentLink and Special:Diff in the interface
Open, NormalPublic

Description

As noted at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=539378665#How_to_edit.E2.80.94or_request_an_edit.E2.80.94of_Special:SpecialPages, Special:PermanentLink is not documented at Special:SpecialPages.


Version: 1.21.x
Severity: enhancement

Details

Reference
bz45221
bzimport set Reference to bz45221.
bzimport added a subscriber: Unknown Object (MLST).

HSJ pointed to https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/SpecialPageFactory.php;h=4d635536a75f42074314abbb51a9b49634d255d8;hb=refs/heads/master#l155

https://en.wikipedia.org/wiki/Special:PermanentLink gives "No such target page". Standard way to "document" such redirects is to use them in the interface, but the sidebar link includes the page title too.

(Hazard-SJ) :P

I would say this affects Special:Diff too.

Fixing this would basically require doing two things for each of the affected special pages:

  • Adding public function isListed() { return true; } (see e.g. SpecialCreateAccount for an example).
  • Making them generate a form with brief instructions instead of an exception when no parameters are provided (see e.g. SpecialComparePages for an example, I think).

(In reply to Bartosz Dziewoński from comment #3)

I would say this affects Special:Diff too.

Fixing this would basically require doing two things for each of the
affected special pages:

  • Adding public function isListed() { return true; } (see e.g. SpecialCreateAccount for an example).
  • Making them generate a form with brief instructions instead of an exception when no parameters are provided (see e.g. SpecialComparePages for an example, I think).

It would be easy to accomplish, but generating a form would mean they would no longer extend RedirectSpecialPage. It's definitely feasible (e.g., mock-up http://pirsquared-dev.wmflabs.org/wiki/Special:PermanentLink), but is there any problem with changing the inheritance?

(In reply to PiRSquared17 from comment #4)

It would be easy to accomplish, but generating a form would mean they would
no longer extend RedirectSpecialPage. It's definitely feasible (e.g.,
mock-up http://pirsquared-dev.wmflabs.org/wiki/Special:PermanentLink), but
is there any problem with changing the inheritance?

There isn't, the SpecialPage subclasses exist only for convenience.
If you are concerned, then you could just override the execute() method.

Change 129095 had a related patch set uploaded by Gerrit Patch Uploader:
Document Special:Diff and Special:PermanentLink

https://gerrit.wikimedia.org/r/129095

Just wondering why a patch submitted for a code review has been apparently just sitting there, not reviewed for over a year now. Can someone explain the status of this. Is it normal for patches to wait over a year to be reviewed?
https://gerrit.wikimedia.org/r/#/c/129095/

Just wondering why a patch submitted for a code review has been apparently just sitting there, not reviewed for over a year now. Can someone explain the status of this. Is it normal for patches to wait over a year to be reviewed?
https://gerrit.wikimedia.org/r/#/c/129095/

@Wbm1058: Thanks for the ping! The patch got reviewed in October 2015 (Siebrand gave a +1 in Gerrit) but it needs rebasing. Would you fancy doing this in order to help moving forward?

In general: According to our statistics the median time to review is 0.6 days. (I don't think we have "time to merge" statistics though?) Unfortunately there are always some patches that fall through the cracks, for numerous reasons. We are working on finding ways to minimize this problem (cf. T78768: Goal: Agree on and implement actions to prioritize code review of patches submitted by volunteers).

Add Comment