Page MenuHomePhabricator
Create Task
Maniphest T50159

VisualEditor: Pre-annotations not working in spans
Closed, ResolvedPublic
Actions

Description

From this bug report on parsoid.wmflabs.org: /mnt/bugs/2013-05-04T01:11:28.439Z-Style_guide%252FAssets_and_gallery

"I typed some text in this paragraph that is styled as a span italic, and VE decided to close and reopen the span on either side of the link. I think that happened before I made the text a link. (This is User:S Page (WMF) here.)"

Relevant diff line below:

−
:<span style="font-style: italic;">See Also: [[Commons:Category:MediaWiki style guide]]</span>

+
:<span style="font-style: italic;">See also: </span>[[Wikimedia Foundation Design/Agora Icon Set]] and<span style="font-style: italic;"> [[Commons:Category:MediaWiki style guide]]</span>

Version: unspecified
Severity: minor

Details

Reference
bz48159

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:43 AM
• bzimport added a project: VisualEditor-ContentEditable.
• bzimport set Reference to bz48159.
ssastry created this task.May 6 2013, 3:01 PM
Jdforrester-WMF added a comment.May 6 2013, 9:41 PM

I think that this partially interacts was a bug that Ed found independently - bug 48110 (now fixed in master). I do not get the span adjusted, but instead get:

:<span style="font-style: italic;">See Also: <a href="Wikimedia_Foundation_Design%2FAgora_Icon_Set" rel="mw:WikiLink">Wikimedia Foundation Design/Agora Icon Set</a> and [[Commons:Category:MediaWiki style guide|<nowiki/>]]<a href="Commons%3ACategory%3AMediaWiki" rel="mw:WikiLink">Commons:Category:MediaWiki</a> style guide</span>

... which is a total mess.

Jdforrester-WMF added a comment.May 16 2013, 3:59 PM

OK, we've fixed the secondary issues I was having; have narrowed down the original bug to pre-annotations not being applied to the insertion of text into this context - changing this to suit.

Esanders added a comment.May 22 2013, 11:22 AM

Can you explain more clearly how this is still broken? What do you mean by pre-annotation?

Jdforrester-WMF added a comment.May 22 2013, 6:38 PM

(In reply to comment #3)

Can you explain more clearly how this is still broken? What do you mean by
pre-annotation?

On re-testing, this comes down to copy-and-paste inserted content not continuing the existing annotations of the styles into which it had been inserted. Marking as such.

  • This bug has been marked as a duplicate of bug 48720 ***
Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits