Page MenuHomePhabricator
Create Task
Maniphest T50551

Formatter: Skin code in MobileFormatter
Closed, InvalidPublic
Actions

Description

There are various bits of HTML that are added in MobileFormatter that would better belong in the Skin itself.

These include back to top link, content_block, section_heading and section classes.

It would be better for the skin to be given a data structure describing the sections similar to what the API returns and let the template (MinervaTemplate) decide how to format this.

It would also be useful to make this less mobile specific so it can be used on the desktop Minerva skin.

Version: unspecified
Severity: normal

Details

Reference
bz48551

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:41 AM
• bzimport added a project: MobileFrontend-stable.
• bzimport set Reference to bz48551.
Jdlrobson created this task.May 16 2013, 9:47 PM
Jdlrobson added a comment.May 16 2013, 9:48 PM

https://gerrit.wikimedia.org/r/#/c/64104/ was a first stab to try and explain this better.

Jdlrobson added a comment.Jun 5 2013, 6:53 PM

This would also allow us to ensure that content_0 is present on all pages and allow us to run photo uploads CTA on the desktop version of Minerva.

Jdlrobson added a comment.Jun 13 2013, 5:59 PM

Max appears to be working on this.

Jdlrobson added a comment.Jul 5 2013, 7:29 PM

To clarify this bug was about moving more control to the template (I got confused with the word skin). It seems ideally that some changes would need to be upstreamed to core for this to happen.

Proof of concept:
https://gerrit.wikimedia.org/r/#/c/70736/

Jdlrobson added a comment.Sep 24 2013, 10:42 PM

I would like to propose we move the formatter code as it is now into SkinMinerva/the Skin class in core so that the desktop Minerva skin can make use of it are there any blockers to doing this?

Jdlrobson added a comment.Nov 12 2013, 6:09 PM

Since SkinMinerva and the formatter have changed drastically this problem doesn't seem so relevant now so closing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL