Page MenuHomePhabricator

VisualEditor: Switching to "edit source" tab within VE triggered via section-edit should be a wikitext section edit
Closed, InvalidPublic

Description

[From bug 48429 comment 20.]

Switching to "edit source" tab when VE was triggered via a section-edit link should enter the wikitext editor for that section, rather than the entire page.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=48429
https://bugzilla.wikimedia.org/show_bug.cgi?id=49665

Details

Reference
bz49664

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:56 AM
bzimport set Reference to bz49664.
TTO added a comment.Jun 18 2013, 2:11 AM

This behavior would be confusing and would break the consistency of the "edit source" tab always going to the whole-page editor.

Perhaps displaying the UI of bug 49666 while in VE edit mode would be a better solution to this. I'd be interested to see the resolution of bug 47779 first though.

Kipod added a comment.Jun 18 2013, 6:45 PM

(In reply to comment #1)

This behavior would be confusing and would break the consistency of the "edit
source" tab always going to the whole-page editor.

forgive my bluntness, but this is plain silly.
what do you mean "source tab always going to the whole page"? we are not discussing "View Source" tab, we are discussing "Edit Source" tab, which is something completely different.
"Edit Source" never even existed before Visual Editor and the reference to "always" does not make any sense: this project is slowly making its way from alpha to beta, and there is no "backward compatibility" or past behavior this thing should feel obliged to.

peace.

(In reply to comment #2)

"Edit Source" never even existed before Visual Editor

Not even remotely true. The "Edit Source" tab is the relabelling of the regular "Edit" tab.

I'm minded to agree with This, that and the other, but willing to be convinced.

(In reply to comment #3)

(In reply to comment #2)

"Edit Source" never even existed before Visual Editor

Not even remotely true. The "Edit Source" tab is the relabelling of the
regular
"Edit" tab.
I'm minded to agree with This, that and the other, but willing to be
convinced.

I see now what you mean, but my point still stands: "edit source" is not something that warrants use of the word "always", as it's completely new, introduced with visual editor... there was no "edit source" anywhere before VE.
for all i care, we do not even need "edit source" on the page when reading it, "Edit" is enough, as long as there *is* "edit source" once VE fires up. as to what should be the action of this "edit source", i believe it should put you in the same spot you would have been if VE was not enabled. in the case you entered edit state through an editsection linkette, this means edit section.

however, it is possible in this case to eat the cake and have it too, by rephrasing the original ticket, so let me try to do this:

ORIGINAL TICKET REPHRASING

When the user press the editsection linkette and VE is enabled, a new top menu item should be generated: "Edit section source", next to "Edit source". pressing this menu item is equivalent to pressing the editsection link when VE is disabled.

Not allowing this functionality basically means that there is no way to execute section edit of wikitext if VE is enabled, which, IMO, is a serious regression.
(alternatively, pressing the "edit source" linkette should open a dialog asking if the user wants to edit the whole article or just the section).

END REPHRASING

peace.

Bug 49665 may be another solution: "VisualEditor: Provide a get-me-into-the-wikitext-editor link on every header".

It looks like there will be an "edit" link and "edit source" link (or icon) on every header.See bug 49666.

If the header "edit source" links (or icons) remain clickable (and/or right-clickable) from within VE, then that would be a solution for getting into the source editor for sections.

In the end we went with bug 49666, which is now done (code to be deployed this afternoon). As discussed above (and I agree), changing behaviour between wikitext section edit behaviour as currently is and the way it works post-VE roll-out - but only on VE-enable-able pages (i.e., not talk pages/etc.) would be complicated and not add value to users.

Consequently, closing this as INVALID.