Page MenuHomePhabricator

VisualEditor: Matching pages list in link dialog should support right-click / ctrl+click to open page in a new window/tab
Closed, ResolvedPublic


A few users at itwp requested that the list of articles you can choose as a wikilink target supports right-click on each title to view the page in another tab; and that disambiguation pages in the same list appear differently (maybe italicized as it currently happens in MediaWiki special pages?) Thanks!

Version: unspecified
Severity: enhancement



Event Timeline

You can use right click or ctrl+click on the links once inserted into the page, but per Bug 48915 this currently leads to the wrong namespace for links other than those to and from the article namespace.

Bug 50240 asks for disambiguation pages to be distinguished in the list, so I'm retitling this one to focus on being able to open the targets with ctrl+click/right click. A user at en.wp has requested this functionality as well.

Both this and bug 50646 should be fixed by making the link suggestions real links, i.e. real <a> tags whose hrefs point to the pages they're suggesting.

To do that, you'd need MWLinkTargetInputWidget to use a specialized subclass of MenuItemWidget; right now it creates plain MenuItemWidgets. Eventually that specialized subclass could be enriched to contain an image and a description etc., per the new designs for the link inspector. We could also use this new widget in MWTitleInputWidget.

(In reply to Roan Kattouw from comment #3)

Both this and bug 50646

Forget about bug 50646, my mistake, that one was about links in a different context. Comment #3 is still valid for this bug though.

Change 171488 had a related patch set uploaded by SuchetaG:
Matching pages from suggestions in link dialog now actually work as links

Change 171488 merged by jenkins-bot:
Matching pages from suggestions in link dialog now actually work as links

The fix is verified in betalabs(beware of a difference between Link and Simple link!). The fix applies to the Link.

Verified the fix in test2 and production.