Page MenuHomePhabricator

Oracle: import doesn't work; insert category fails
Closed, ResolvedPublic

Description

Importing pages...

Import failed: A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script Query: INSERT INTO /*Q*/CATEGORY (cat_title,cat_pages,cat_subcats,cat_files) VALUES (:cat_title, :cat_pages, :cat_subcats, :cat_files) Function: DatabaseOracle::insertOneRow Error: 1400 ORA-01400: cannot insert NULL into ("WIKI"."CATEGORY"."CAT_ID")


Version: 1.22.0
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=58435

Details

Reference
bz53710

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz53710.
bzimport added a subscriber: Unknown Object (MLST).
Petrb created this task.Sep 3 2013, 1:16 PM
Petrb added a comment.Sep 3 2013, 1:20 PM

It seems that category inserting is completely broken :o

the category count was changed with gerrit 66999. Getting a new sequence was removed there (or should be done by the upsert).

I havent tried to reproduce this yet, but I suspect it is still a bug, and affects any addition of a category (i.e. not just import/export).

Database::upsert() calls ::insert() , which in DatabaseOracle doesnt add the sequence using ::getSequenceData()

Change 110991 had a related patch set uploaded by Umherirrender:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/110991

Change 110991 merged by jenkins-bot:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/110991

was successfully merged

target release is 1.22 -> flag for backport

Change 115395 had a related patch set uploaded by MarkAHershberger:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/115395

Change 115395 merged by jenkins-bot:
Add sequence support for upsert in DatabaseOracle

https://gerrit.wikimedia.org/r/115395