Page MenuHomePhabricator

Language selection should cancel with X but does not
Closed, InvalidPublic

Description

Log in to http://en.wikipedia.beta.wmflabs.org/

on any page:

  • click the cog icon, get Language settings/Display UI
  • click the ellipsis button (...)
  • type 'de'
  • choose 'Deutsch'
  • click 'Input'; display switches to German
  • click 'X' to close the dialog
  • click the cog icon again

UI for ULS should be in English but is in German.

put another way: upon clicking 'X' to close the ULS dialog without saving, ULS should return to default settings, in this case English. Instead, ULS continues to use (German) language settings that have not been saved after the user closes the dialog via the X button

This is the behavior specified in line 55 of the automated test scenario in https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/tests/browser/features/uls_settings_panel.feature


Version: unspecified
Severity: normal

Details

Reference
bz53726

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:47 AM
bzimport set Reference to bz53726.
bzimport added a subscriber: Unknown Object (MLST).

Change 82548 had a related patch set uploaded by Cmcmahon:
give this fix +2 in order to see Bug 53726 caught by this test

https://gerrit.wikimedia.org/r/82548

Change 82548 abandoned by Cmcmahon:
give this fix +2 in order to see Bug 53726 caught by this test

Reason:
overtaken by history

https://gerrit.wikimedia.org/r/82548