Page MenuHomePhabricator

Archiving of feedback broken on enwiki
Open, LowestPublic

Description

Archiving disabled in https://gerrit.wikimedia.org/r/#/c/84469/

Archiving seems to be broken as the bot/job is repeatedly archiving the same set of feedback, but the items haven't been archived.

Relatedly, the log entry should only be created if archiving actually succeeded

01:13 (Article feedback activity log)‎ . . [Article Feedback V5‎ (57×)]

	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:13 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #755805 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)
	01:12 . . Article Feedback V5 (Talk | block) archived feedback post #759669 on Cloud computing ‎(Archived after 30 days of editor inactivity)

Version: master
Severity: normal

Details

Reference
bz54197

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:52 AM
bzimport set Reference to bz54197.
bzimport added a subscriber: Unknown Object (MLST).

Brain dump:

Looking at e.g. feedback #755805 (https://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Cloud_computing/755805), this feedback entry is actually archived. DB data confirms: aft_archive = 1.

Only the maintenance script, which has since been killed, can mark feedback as archived. Activity log confirms the last action was performed by Article Feedback v5.

Where-condition, executed against slave, is: array( 'aft_archive = 0', "aft_archive_date <= '$now'" ). This means that this post should no longer appear when queried for "posts to be archived".

I'd say that perhaps slave is/was lagging, but the wait is right there in the code, and I'll assume it works:

wfWaitForSlaves( false, false, $wgArticleFeedbackv5Cluster );

Also, the script had been going at it for 10+ minutes (another feedback entry for even way longer) until it was killed, so that lag would have to have been pretty bad. This is a highly unlikely cause.

It looks like the archiving kicked in right after a person manually un-archived the feedback.
*ERROR #1*: archive date should be re-calculated after a person un-archives feedback (or nulled completely), not be the original archive date (which results in immediate re-archive).

(probably unrelated) *ERROR #2*: maintenance script nulls aft_archive_date, but the subsequent update() call will fill out that value again.

Have to run for now, will get these fixed and continue figuring out why exactly archive broke.

Fabrice or Matthias: is anyone actively working on this issue? If not, it may make sense to disable AFTv5 on Wikimedia wikis if it can't be actively maintained.

For reference: https://www.mediawiki.org/wiki/Article_feedback/status#2013-10-monthly.

(In reply to comment #4)

Fabrice or Matthias: is anyone actively working on this issue? If not, it may
make sense to disable AFTv5 on Wikimedia wikis if it can't be actively
maintained.

Seconded. If I'm not mistaken, there is no longer any "Archive" filter anywhere: it seems ArticleFeedbackv5AutoArchiveEnabled controls both past and future archival, so that setting it false actually de-archived humongous masses of unreviewed feedback, with all the vandalism they include.

(In reply to comment #5)

(In reply to comment #4)

Fabrice or Matthias: is anyone actively working on this issue? If not, it may
make sense to disable AFTv5 on Wikimedia wikis if it can't be actively
maintained.

Seconded. If I'm not mistaken, there is no longer any "Archive" filter
anywhere: it seems ArticleFeedbackv5AutoArchiveEnabled controls both past and
future archival, so that setting it false actually de-archived humongous
masses
of unreviewed feedback, with all the vandalism they include.

After two more months of useless waiting, this is now finally proceeding: https://gerrit.wikimedia.org/r/#/c/112639/ , bug 61163.

[Lowering priority to reflect reality, as AFTv5 is not very actively being worked on anymore.]

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

All development work on AbuseFilter v.5 (and indeed, previous versions) is halted. The project is archived, so having open tasks is inappropriate. Consequently, I'm closing all tasks.

AbuseFilter --> ArticleFeedback...

@Jdforrester-WMF @ashley

All development work on AbuseFilter v.5 (and indeed, previous versions) is halted. The project is archived, so having open tasks is inappropriate. Consequently, I'm closing all tasks.

The development has resumed.

May we re-open all tasks, such as for example this one, so that interested volunteers may start writing patches for them and submit these patches for review?

It's certainly good to reopen reports on potentially critical bugs, though this one is probably quite hard to debug.