Page MenuHomePhabricator

Cleanup upload code
Open, MediumPublic

Description

PronunciationRecording currently use UploadWizard's upload code. However, PronunciationRecording workarounds (and a couple hacks) to deal with the fact that that upload code is not fully modular (it reaches into other parts of UploadWizard).

This should be cleaned up so that the dependencies make sense. Part of this will have to be on the UploadWizard side (https://gerrit.wikimedia.org/r/#/c/84344/).

After that, PronunciationRecording will need to be adapted accordingly, fixing this bug.

In the future, it would be good to have the client upload code in core, but that is not in the scope of this bug.


Version: unspecified
Severity: normal
See Also:
T51988: Use Deferred/Promise and generally async-friendly code paths instead of jquery.pubsub
T64513: Create mw.Api.plugin.upload for uploading from MediaWiki frontend code

Details

Reference
bz54724

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:23 AM
bzimport set Reference to bz54724.

(In reply to Matthew Flaschen from comment #0)

In the future, it would be good to have the client upload code in core, but
that is not in the scope of this bug.

I think it's an important matter we should keep track of. Has it a Bugzilla entry?

(In reply to Rainer Rillke @commons.wikimedia from comment #1)

(In reply to Matthew Flaschen from comment #0)

In the future, it would be good to have the client upload code in core, but
that is not in the scope of this bug.

I think it's an important matter we should keep track of. Has it a Bugzilla
entry?

Not that I know of. Just filed as bug 62513.

Gilles triaged this task as Medium priority.Nov 24 2014, 2:49 PM
Gilles added a subscriber: Gilles.
Krinkle added a subscriber: Krinkle.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptAug 22 2015, 7:00 AM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:38 PM
Danny_B moved this task from Unsorted to Cleanup on the Technical-Debt board.Jan 22 2016, 11:36 PM
Krinkle removed a subscriber: Krinkle.Mar 28 2017, 2:44 AM