Page MenuHomePhabricator
Create Task
Maniphest T51988

Use Deferred/Promise and generally async-friendly code paths instead of jquery.pubsub
Closed, ResolvedPublic
Actions

Description

Right now we do a lot of homebrew asynchronous programming, which might have been fine before, but we have jQuery.Deferred and jQuery.Promise now! Let's clean this up and be uniform about it.

Version: master
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54724

Details

Reference
bz49988
SubjectRepoBranchLines +/-
Get rid of pubsub once and for allmediawiki/extensions/UploadWizardmaster+120 -217
Use promises for getting image infomediawiki/extensions/UploadWizardmaster+465 -563
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:50 AM
• bzimport added projects: UploadWizard, JavaScript.
• bzimport set Reference to bz49988.
• bzimport added a subscriber: Unknown Object (MLST).
MarkTraceur created this task.Jun 21 2013, 11:22 PM
• Gilles added a project: Multimedia.Nov 24 2014, 3:34 PM
MarkTraceur moved this task from Untriaged to Needs code review on the Multimedia board.Jan 12 2015, 10:43 PM
• Gilles assigned this task to MarkTraceur.Jan 14 2015, 4:27 PM
• Gilles subscribed.

Make the changesets reference the bug so that they appear here?

• Mattflaschen-WMF unsubscribed.Jan 15 2015, 5:14 AM
gerritbot added a project: Patch-For-Review.Jan 15 2015, 11:47 PM
gerritbot subscribed.

Change 146604 had a related patch set uploaded (by Gergő Tisza):
Use promises for getting image info

https://gerrit.wikimedia.org/r/146604

Patch-For-Review

Tgr moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Jan 16 2015, 6:27 AM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Jan 20 2015, 11:05 PM
Tgr moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Jan 23 2015, 11:57 PM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Feb 2 2015, 9:22 PM
• Gilles moved this task from Needs code review to Batch Move 2019-03-06 on the Multimedia board.Feb 16 2015, 2:27 PM

Blocked for now in favor of better browser test coverage

• Gilles moved this task from Batch Move 2019-03-06 to Untriaged on the Multimedia board.Apr 6 2015, 9:20 AM
MarkTraceur added a parent task: T96906: Refactor UploadWizard to be maintainable.Apr 22 2015, 8:08 PM
matmarex merged a task: T287: Use promises for image info getter methods in UploadWizardUpload.Apr 24 2015, 7:57 PM
matmarex merged a task: T77672: Remove jquery.pubsub from UploadWizard.Apr 24 2015, 8:00 PM
matmarex added subscribers: Aklapper, MingleTerminator.
matmarex merged a task: T285: Kill jquery.pubsub.js, use promises.Apr 24 2015, 8:03 PM
matmarex added a subscriber: Ricordisamoa.
• Gilles unsubscribed.Apr 27 2015, 7:51 AM
Jdforrester-WMF moved this task from Untriaged to Doing on the Multimedia board.Apr 30 2015, 4:08 PM
MarkTraceur moved this task from Doing to Next up on the Multimedia board.Sep 4 2015, 5:17 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 5:17 PM
gerritbot added a comment.Sep 23 2015, 2:28 PM

Change 146604 abandoned by Bartosz Dziewoński:
Use promises for getting image info

Reason:
No longer merges, and we did some work in this area in other patches. Probably better to start from scratch.

https://gerrit.wikimedia.org/r/146604

matmarex renamed this task from Use Deferred/Promise and generally async-friendly code paths where possible to Use Deferred/Promise and generally async-friendly code paths instead of jquery.pubsub.Sep 23 2015, 2:28 PM
matmarex removed MarkTraceur as the assignee of this task.
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
matmarex removed subscribers: gerritbot, • wikibugs-l-list.
matmarex subscribed.Sep 23 2015, 2:32 PM

The work done so far:

  • {3590770bf9754ba8eba021a88c33a0bc36395ebc} (which got rid of the simpler half of pubsub usage)
  • {4fcb727d4a3f8cc5cf57fdff1b564aa038883491} (which got rid of the gnarliest weirdness of the harder half of pubsub usage, that we really couldn't figure out why it worked at all)
MarkTraceur moved this task from Next up to Prototyping on the Multimedia board.Oct 5 2015, 3:49 PM
matmarex claimed this task.Oct 26 2015, 4:37 PM
gerritbot added a comment.Oct 26 2015, 4:37 PM

Change 248908 had a related patch set uploaded (by Bartosz Dziewoński):
Get rid of pubsub once and for all

https://gerrit.wikimedia.org/r/248908

gerritbot added a project: Patch-For-Review.Oct 26 2015, 4:37 PM
gerritbot added a comment.Nov 2 2015, 8:14 PM

Change 248908 merged by jenkins-bot:
Get rid of pubsub once and for all

https://gerrit.wikimedia.org/r/248908

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Nov 2 2015, 9:00 PM
matmarex closed this task as Resolved.Nov 3 2015, 3:38 PM

And {1107ab8100e61835739a52bfb27c6b8f3d0995ae} finished the job. Look ma, no pubsub!

matmarex mentioned this in T121202: enlargement of thumbs in UW does not work any more.Dec 16 2015, 10:10 AM
Liuxinyu970226 mentioned this in T56724: Cleanup upload code.Mar 27 2017, 3:38 PM
Krinkle awarded a token.Mar 28 2017, 2:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits