Page MenuHomePhabricator
Create Task
Maniphest T57976

VisualEditor: Dialogs should disable "Apply changes" until a change is present
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Seen in Reference and Transclusion, anywhere with an overlay containing a button saying 'Apply changes'.

  • Hover the cursor over an existing Reference or Transclusion.
  • Click the icon to invoke the Reference or Transclusion overlay
  • Without making any changes, click 'Apply changes'
  • Save page button goes from grey to active.
  • Click Save page
  • Click Review your changes.

Get message "Could not start the review because your revision matches the latest version of this page."

Version: unspecified
Severity: minor

Details

Reference
bz55976
SubjectRepoBranchLines +/-
Don't re-enable apply changes in reference dialog if the changes have been undonemediawiki/extensions/VisualEditormaster+14 -3
Disable Apply Changes in reference dialog until changes have been mademediawiki/extensions/VisualEditormaster+22 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:22 AM
• bzimport added projects: VE-deploy-nextup, VisualEditor-EditingTools.
• bzimport set Reference to bz55976.
• Cmcmahon created this task.Oct 21 2013, 8:46 PM
Catrope added a comment.Oct 24 2014, 2:49 AM

This is not an OOUI bug, moving back to VE. Rather, it's a bug in the individual dialogs in VE that apparently commit no-op transactions when you click Apply changes without changing anything. Also, in most dialogs we disable the Apply changes button when there is nothing to change.

Since this bug was filed in 2013, I imagine it might be mostly fixed now? We have some bugs in this area (filed individually as "Apply changes is enabled even though XYZ") but my impression is that generally we're pretty good about this now.

Krenair added a comment.Oct 24 2014, 11:18 PM

No, I think this still applies to the places mentioned in the description (transclusions and references).

Jdforrester-WMF added a comment.Nov 19 2014, 12:34 AM
  • Bug 58231 has been marked as a duplicate of this bug. ***
Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:47 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Nov 23 2014, 11:02 PM
Jdforrester-WMF removed a project: VE-deploy-nextup.Nov 24 2014, 10:02 PM
gerritbot added a project: Patch-For-Review.Dec 2 2014, 1:31 AM

Change 176861 had a related patch set uploaded (by Alex Monk):
Disable Apply Changes in reference dialog until changes have been made

https://gerrit.wikimedia.org/r/176861

Patch-For-Review

gerritbot added a comment.Dec 5 2014, 10:46 PM

Change 176861 merged by jenkins-bot:
Disable Apply Changes in reference dialog until changes have been made

https://gerrit.wikimedia.org/r/176861

gerritbot added a comment.Dec 5 2014, 11:51 PM

Change 177944 had a related patch set uploaded (by Alex Monk):
Don't re-enable apply changes in reference dialog if the changes have been undone

https://gerrit.wikimedia.org/r/177944

Patch-For-Review

gerritbot added a comment.Dec 6 2014, 12:56 AM

Change 177944 merged by jenkins-bot:
Don't re-enable apply changes in reference dialog if the changes have been undone

https://gerrit.wikimedia.org/r/177944

Krenair removed a project: Patch-For-Review.Dec 6 2014, 1:21 AM
Krenair set Security to None.

I kind of wish this had been broken into one bug for each dialog.

Jdforrester-WMF added a comment.Dec 6 2014, 1:45 AM
In T57976#823009, @Krenair wrote:

I kind of wish this had been broken into one bug for each dialog.

Done. :-)

Krenair added a comment.Dec 6 2014, 1:51 AM

So this is now a tracker?

Jdforrester-WMF added a comment.Dec 6 2014, 1:56 AM
In T57976#823066, @Krenair wrote:

So this is now a tracker?

No, it's a single task made up of sub-tasks.

Krenair closed subtask T76928: The reference dialog should disable the "Apply changes" button until a change is present as Resolved.Dec 9 2014, 1:34 AM
Krenair mentioned this in rEVEDdb4d034fd746: Disable Apply Changes in reference dialog until changes have been made.Dec 10 2014, 7:34 PM
Krenair mentioned this in rEVEDfc6eaf6825c8: Don't re-enable apply changes in reference dialog if the changes have been….Dec 10 2014, 7:42 PM
Krenair claimed this task.Dec 24 2014, 2:19 AM
Krenair added a project: Patch-For-Review.Jan 6 2015, 2:21 AM

A single patch fixes the majority of the issues here, see the subtasks.

Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Jan 6 2015, 5:58 PM
Krinkle unsubscribed.Jan 30 2015, 8:37 PM
Jdforrester-WMF closed this task as Resolved.Feb 10 2015, 11:17 PM
Jdforrester-WMF closed subtask T76926: The transclusion dialog should disable the "Apply changes" button until a change is present as Resolved.
Jdforrester-WMF closed subtask T76927: The citation dialog should disable the "Apply changes" button until a change is present as Resolved.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.
Jdforrester-WMF edited projects, added WMF-deploy-2015-02-11_(1.25wmf17); removed Patch-For-Review.
Etonkovidova added a project: Verified-in-Phase0.Feb 12 2015, 11:24 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Aug 5 2015, 12:16 AM
Jdforrester-WMF edited a custom field.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits