Page MenuHomePhabricator
Create Task
Maniphest T60213

Warning with PCRE<7.2: preg_match(): Compilation failed: assertion expected after (?( at offset 115 in /var/www/html/w/includes/utils/IP.php on line 88
Closed, ResolvedPublic
Actions

Description

When trying to install MediaWiki on CentOS 5 (using the packaged version of PHP 5.3.3), I got the following error:

Creating administrator user account... Warning: preg_match(): Compilation failed: assertion expected after (?( at offset 115 in /var/www/html/w/includes/utils/IP.php on line 88 Warning: preg_match(): Compilation failed: assertion expected after (?( at offset 115 in /var/www/html/w/includes/utils/IP.php on line 88 done

This is probably because of gerrit 66304, which rendered the regex
RE_IPV6_ADD incompatible with the PCRE 6.6 that comes with CentOS 5,
though CentOS 6 should be fine.

So we have two options:

  • decide not to support PHP binaries that are built to use a system version of PCRE older than 7.2, adding to the installer a check for this; or
  • revert the change.

In either case, the patch should be backported to 1.22.

Version: 1.22.0
Severity: normal

Details

Reference
bz58213

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:34 AM
• bzimport added projects: MW-1.22-release, MediaWiki-Installer.
• bzimport set Reference to bz58213.
• bzimport added a subscriber: Unknown Object (MLST).
PleaseStand created this task.Dec 9 2013, 3:04 PM
gerritbot added a comment.Dec 9 2013, 4:32 PM

Change 100390 had a related patch set uploaded by PleaseStand:
Restore compatibility with curl < 7.16.2

https://gerrit.wikimedia.org/r/100390

PleaseStand added a comment.Dec 9 2013, 4:33 PM

(In reply to comment #1)

Change 100390 had a related patch set uploaded by PleaseStand:
Restore compatibility with curl < 7.16.2

https://gerrit.wikimedia.org/r/100390

Wrong bug...

hashar added a comment.Dec 9 2013, 7:31 PM

I guess the CentOS version of PHP is compiled with a specific PCRE version which is most probably the one coming with the OS instead of the one bundled within PHP.

Kevin can you run php -i and paste there the 'pcre' section? Example output for me (Mac OS X):

pcre

PCRE (Perl Compatible Regular Expressions) Support => enabled
PCRE Library Version => 8.02 2010-03-19

Directive => Local Value => Master Value
pcre.backtrack_limit => 1000000 => 1000000
pcre.recursion_limit => 100000 => 100000

On a Precise instance having php5 5.3.10-1ubuntu3.8+wmf2

PCRE Library Version => 8.12 2011-01-15

Can you also paste the result of ldd /usr/bin/php |fgrep pcre. Again on Precise that yields:

libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007f6a65e75000)

Then use readlink against the /lib.. file to find out the version:

$ readlink /lib/x86_64-linux-gnu/libpcre.so.3
libpcre.so.3.12.1
$

And the version of libpcre has given by rpm or yum :-D

PHP 5.3.3 (out in July 2010) comes with bundled PCRE version 8.0. Additionally CentOS package does not use the expected pcre version so I am afraid this bug is going to be a WONTFIX.

PleaseStand added a comment.Dec 10 2013, 12:34 AM

(In reply to comment #3)

Kevin can you run php -i and paste there the 'pcre' section? Example output
for me (Mac OS X):

Configure Command => './configure' '--build=i386-redhat-linux-gnu'
[...] '--with-pcre-regex=/usr' [...]

pcre

PCRE (Perl Compatible Regular Expressions) Support => enabled
PCRE Library Version => 6.6 06-Feb-2006

Directive => Local Value => Master Value
pcre.backtrack_limit => 100000 => 100000
pcre.recursion_limit => 100000 => 100000

So yes, the PCRE version is the problem.

PHP 5.3.3 (out in July 2010) comes with bundled PCRE version 8.0.
Additionally
CentOS package does not use the expected pcre version so I am afraid this bug
is going to be a WONTFIX.

Agreed. I nevertheless filed this report so I have something to refer to when I add an installer check for it.

PleaseStand added a comment.Dec 10 2013, 7:48 AM
  • Bug 58253 has been marked as a duplicate of this bug. ***
PleaseStand added a comment.Dec 10 2013, 8:59 AM

So if we don't revert the change, for those who are stuck on RHEL/CentOS 5 and are using that distribution's php53 package, we would advise upgrading to PHP 5.4 using any of several unofficial RPMs/repos that don't use the system PCRE.

Would that be an acceptable answer, or is it in fact necessary to support the base install of this six-year-old distribution for a little while longer (until PHP 5.3 support is dropped)?

Anomie added a comment.Dec 10 2013, 4:04 PM

(In reply to comment #6)

So if we don't revert the change, for those who are stuck on RHEL/CentOS 5
and
are using that distribution's php53 package, we would advise upgrading to PHP
5.4 using any of several unofficial RPMs/repos that don't use the system
PCRE.

They could as well upgrade to a php53 package that wasn't compiled against the system PCRE.

It may even be possible that they could just upgrade their system PCRE.

• MZMcBride added a comment.Dec 10 2013, 7:32 PM

Discussion is getting split between this bug and bug 58253.

Copying the Marks and bug 58253 is cross-referenced with [[mw:MediaWiki 1.22/Known issues]].

gerritbot added a comment.Dec 17 2013, 7:14 AM

Change 102081 had a related patch set uploaded by PleaseStand:
Check for very old PCRE versions in installer and updater

https://gerrit.wikimedia.org/r/102081

Mglaser added a comment.Jan 3 2014, 5:47 PM

The patch points to a MediaWiki page that is supposed to offer some explanation:
https://www.mediawiki.org/wiki/Manual:Errors_and_symptoms/PCRE

However, that page is empty. Is there a better article to point to?

• matmarex added a comment.Jan 3 2014, 5:52 PM

As explained in the comments on the patch, that page is currently a draft
located in user-space.

Aklapper added a comment.Jan 7 2014, 3:00 PM
  • Bug 59765 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Jan 21 2014, 10:39 PM

Change 108843 had a related patch set uploaded by MarkAHershberger:
Check for very old PCRE versions in installer and updater

https://gerrit.wikimedia.org/r/108843

gerritbot added a comment.Jan 21 2014, 10:44 PM

Change 108843 merged by jenkins-bot:
Check for very old PCRE versions in installer and updater

https://gerrit.wikimedia.org/r/108843

gerritbot added a comment.Jan 21 2014, 10:45 PM

Change 102081 merged by jenkins-bot:
Check for very old PCRE versions in installer and updater

https://gerrit.wikimedia.org/r/102081

Aklapper added a comment.Jan 22 2014, 12:15 AM

Patch merged to 1.22.x and git master. Closing as FIXED.

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits