Page MenuHomePhabricator
Create Task
Maniphest T60724

VisualEditor: Command-x (cut) triggers browser's Undo (Command-z) in Safari
Closed, ResolvedPublic
Actions

Description

Intention:
Move a section of a page by cutting it out of one place and pasting it into the right place.

Steps to Reproduce:

  1. Close an unwanted browser tab.
  2. Select several paragraphs in VisualEditor.
  3. Press Command-x to cut (not just copy) the material.
  4. Notice that the just-closed browser window has reappeared. (Command-z/Undo in Safari reopens a tab that you just closed.)

Reproducible: Always

I am unable to reproduce this in Firefox, presumably because selecting text within VisualEditor seems to clear (or otherwise make unavailable) the 'undo' buffer. So even if VisualEditor is telling Firefox to undo something, Firefox believes that there there's nothing to undo.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57217

Details

Reference
bz58724

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:38 AM
• bzimport added projects: Browser-Support-Apple-Safari, VE-deploy-2014-08-28, VisualEditor-EditingTools.
• bzimport set Reference to bz58724.
• Whatamidoing-WMF created this task.Dec 20 2013, 12:21 AM
Jdforrester-WMF added a comment.Aug 21 2014, 5:32 PM

Ick. This feels like a pretty poor browser bug here…

• bzimport added a comment.Aug 27 2014, 5:29 PM

aditya wrote:

Patch to prevent undo on cut

Here's a patch that avoids the 'undo' execCommand and fixes the issue for me in Chromium 36.0.1985.125 (Linux).

I'm assuming that the timeout was originally intended to let the code in that block be safely executed only after the browser manipulated (deleted) the selection. It appears that this no longer works and the code is processed before the text is actually deleted.

Therefore this change uses preventDefault() to not let the browser do it's thing, and directly handles the entire removal with a transaction.

This is my first patch to VE, sorry if I made any obvious mistakes. :)

Attached:

0001-Avoid-undo-when-processing-a-cut-event.patch2 KBDownload

• bzimport added a comment.Aug 27 2014, 6:40 PM

aditya wrote:

Pushed a patch to gerrit.

https://gerrit.wikimedia.org/r/#/c/156593/

gerritbot added a comment.Aug 27 2014, 6:54 PM

Change 156593 had a related patch set uploaded by Catrope:
Avoid undo when processing a cut event.

https://gerrit.wikimedia.org/r/156593

gerritbot added a comment.Aug 27 2014, 11:56 PM

Change 156733 had a related patch set uploaded by Catrope:
Avoid undo when processing a cut event.

https://gerrit.wikimedia.org/r/156733

gerritbot added a comment.Aug 27 2014, 11:57 PM

Change 156593 abandoned by Catrope:
Avoid undo when processing a cut event.

Reason:
Duplicate of https://gerrit.wikimedia.org/r/156593

https://gerrit.wikimedia.org/r/156593

gerritbot added a comment.Aug 27 2014, 11:57 PM

Change 156593 restored by Catrope:
Avoid undo when processing a cut event.

Reason:
Whoops, obviously this isn't a duplicate of itself...

https://gerrit.wikimedia.org/r/156593

gerritbot added a comment.Aug 27 2014, 11:58 PM

Change 156733 abandoned by Catrope:
Avoid undo when processing a cut event.

Reason:
Duplicate of https://gerrit.wikimedia.org/r/156593

https://gerrit.wikimedia.org/r/156733

gerritbot added a comment.Aug 28 2014, 12:11 PM

Change 156776 had a related patch set uploaded by Esanders:
Remove unnecessary execCommand('undo') from onCut

https://gerrit.wikimedia.org/r/156776

gerritbot added a comment.Aug 28 2014, 12:49 PM

Change 156776 merged by jenkins-bot:
Remove unnecessary execCommand('undo') from onCut

https://gerrit.wikimedia.org/r/156776

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:57 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits