def treat should be moved to pywikibot/textlib.py (as 'replaceLinks(text, fromPage, toPage)')
Version: core-(2.0)
Severity: normal
Description
Description
Details
Details
- Reference
- bz59686
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T60942 Features to move from scripts to framework (tracking) | |||
| Open | None | T151110 RFC: Regressions of core should be rethought or solved | |||
| Open | None | T61686 fixing_redirects.py: use textlib.replace_links() instead of FixingRedirectBot.replace_links() | |||
| Open | None | T104805 textlib.replace_links() does not work as expected | |||
| Open | None | T125372 Add documentation to textlib.replace_links |
Event Timeline
Comment Actions
Change 137802 had a related patch set uploaded by Ricordisamoa:
move treat() out of fixing_redirects.py, as generic textlib.replaceLinks()
Comment Actions
Change 137802 had a related patch set uploaded (by XZise):
New textlib.replace_links() link replacements
Comment Actions
I don't know why gerritbot commented again but as you can see the same patch (which is still authored by you) was reported by @gerritbot a year ago.
Comment Actions
I cannot commit (pun intended) to that patch anymore. Feel free to place it back up for grabs.
Comment Actions
reopened due to the revert with 8a7c42f50ac1c99b99d7cac9c because of the regression made by 18e6c9b1e655a807ce0ab732880c9874093cef1b
Comment Actions
Change 491673 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [IMPR] Fix weirdly broken replace_links to behave more expectable
Comment Actions
Change 491884 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix the behavior of fixing_redirects.py
Comment Actions
Change 491884 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix the behavior of fixing_redirects.py
Comment Actions
Change #491673 abandoned by JJMC89:
[pywikibot/core@master] [IMPR] Fix weirdly broken replace_links to behave more expectable
Reason:
stale patch that cannot be merged - feel free to unabandon if you will update it
Comment Actions
Change #491884 abandoned by JJMC89:
[pywikibot/core@master] [bugfix] Fix the behavior of fixing_redirects.py
Reason:
stale patch that cannot be merged - feel free to unabandon if you will update it
Comment Actions
Change #1282976 had a related patch set uploaded (by Raushan 31; author: Raushan 31):
[pywikibot/core@master] [IMPR] Move redirect replacement logic to textlib.replaceLinks
Comment Actions
treat() was already replaced in rPWBC18e6c9b but reverted in rPWBC8a7c42f due to an insufficient implementation of textlib.replace_links() and breaking changes (see comments above). The
fixing_redirects.FixingRedirectBot.replace_links() method should be replaces by the textlib.replace_links() function after the implementation has been fixed or improved.
Comment Actions
Change #1282976 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Move redirect replacement logic to textlib.replaceLinks
Reason:
Duplicate implemetation of replace_links