Page MenuHomePhabricator

Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message
Closed, ResolvedPublic

Description

From bug 53069 comment 3, there should be a mobile equivalent of the [[MediaWiki:anoneditwarning]] message.

The default value of the message is:

Warning: You are not logged in. Your IP address will be recorded in this page's edit history.

(from https://translatewiki.net/wiki/MediaWiki:Anoneditwarning)

I tried looking in the code to figure out where it should go, but I really didn't understand how the template system works. I'll try and find some documentation.


Version: unspecified
Severity: enhancement

Details

Reference
bz59937

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:38 AM
bzimport set Reference to bz59937.
Legoktm created this task.Jan 11 2014, 5:36 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1615

Change 106865 had a related patch set uploaded by Legoktm:
Add mobile version of "anoneditwarning" message

https://gerrit.wikimedia.org/r/106865

kwang wrote:

Hi Legoktm. We have decided not to approve this patch as the warning takes up too much of the limited screen real estate of the edit screen. However, anonymous mobile editing is an area that we are looking into. In the next few days we will be publishing a preliminary plan for enabling anonymous editing within mobile. This will be published on mediawiki.org and available for comment by the community. When that is published I will also post a link to that here.

(In reply to comment #3)

Hi Legoktm. We have decided not to approve this patch as the warning takes up
too much of the limited screen real estate of the edit screen. However,
anonymous mobile editing is an area that we are looking into. In the next few
days we will be publishing a preliminary plan for enabling anonymous editing
within mobile. This will be published on mediawiki.org and available for
comment by the community. When that is published I will also post a link to
that here.

Really, screen real-estate trumps warnings that we would arguably be morally remiss not to include?

Brian to be clear currently we don't enable anonymous editing. On an iPhone the message with such a patch would take up half the screen so yes :)

Let's do this properly... An intermediate screen would be much better on a mobile phone and if someone submits a patch that does that I will happily merge.

Also FYI the patch does not work so that kinda needs to be fixed ;-).

I Interpreted (perhaps misinterpreted) comment 3 as saying that anon warnings were going to not be present on mobile with anon editing eventually being enabled (ie I thought comment 3 was an attempt to wontfix this bug), which I would strongly object to.

Provided the plan is to have a warning when anon editing is on (In some form or another), I'm happy. Personally my initial reaction is that an intermediate screen with click-through seems like too big of a warning, but I'm sure you guys will experiment and come up with something that works. I'm not really concerned with what it is provided that it is present.

Change 106865 abandoned by Legoktm:
Add mobile version of "anoneditwarning" message

Reason:
Per comments on bug and CR, not the best way to go about this.

https://gerrit.wikimedia.org/r/106865

(In reply to comment #3)

Hi Legoktm. We have decided not to approve this patch as the warning takes up
too much of the limited screen real estate of the edit screen. However,
anonymous mobile editing is an area that we are looking into. In the next few
days we will be publishing a preliminary plan for enabling anonymous editing
within mobile. This will be published on mediawiki.org and available for
comment by the community. When that is published I will also post a link to
that here.

Awesome, looking forward to it :) I think that link will go better on bug 53069 though.

kwang wrote:

I've commented on bug 53069

(In reply to Jon from comment #5)

Let's do this properly... An intermediate screen would be much better on a
mobile phone and if someone submits a patch that does that I will happily
merge.

Updating summary. I think that to reject legoktm's patch one should first submit an alternative patch, rather than block progress. Any other taker?

There are only two contradictory possibilities:

  1. either this bug is serious enough to be a blocker of bug 53069, and any solution is therefore better than none;
  2. or this bug is not a blocker of bug 53069.

Mobile team, which do you pick?

I'm not from mobile team, but in my opinion:
If mobile anon editing is enabled, we must have a solution to clear up the user, that he is editing as an anonymous user and his actual IP adress will be displayed in public. This point must be (how i said, in my opinion) considered critical as the point, that a user must have the chance to edit as anonymous i think :)

And for now we have 3 (if i'm right) ways to solve it:

  1. Show warning to be anonymous in editor -> bad solution on mobile display
  2. Show an extra screen before (or after) preview with (maybe more then anonwarning) warnings and infos -> maybe a solution, but a new screen the user must click through with only information and warnings?
  3. Show warning in preview screen -> here is the same problem as 1.: The screen on mobile devices is very limited, so the user has to scroll to the preview.

Maybe a 4. solution:
A firstly invisible warning and a link/button (maybe in red or orange) that says:
"There are warnings to this edit" (or another text). If the user clicks on that, the invisible element will be visible and the user can read the warning. If the user knows, what the warning is, only one line is used for this.

I have little time to focus on writing patches around anonymous editing. I tried [1] but was too busy to see it through to completion. If anyone wants to continue this please be my guest.

The main issue with the patch from legoktm that I said in review was that it didn't work. This is an important thing to check before merging code :)

Basically what needs to happen if you want to move this along and want my help +2ing such a change (which I will happily do):

  1. When $wgAnonymousEditing is enabled and the user clicks the edit button they see a AnonEditWarningOverlay
  2. When edit is clicked in that overlay they are taken to the editor and can commence editing.
  3. When they go through the workflow it should finish with a save.

Note the anonymous editing workflow is still very much in flux, so don't worry too much for the time being about styling it nicely - just reuse the existing overlay styles we have in mobile.

Also feel free to enable it by default in the experimental mode of the site, I think we can manage the traffic there and it would give us useful data around what anonymous editing on mobile might look like.

[1] https://gerrit.wikimedia.org/r/#/c/117324/

@Jon: Your PS, i think, is the right way and the basic function is in there, but it needs a lot of work and investigating in what to do after edit (onSave e.g.) to hide the login drawer, and enable edit button after the load of the new page (in alpha with ajax) and so on. MAYBE i will have a look at this, BUT i'm really new at MF, so not too much hope :)

I think for the purposes of alpha we could either simply kill the anonymous CTA drawer, or update it to include a link in the drawer to "I want to edit anonymously". When clicked, the drawer would close and the editor would open and the workflow would be exactly the same.

Change 138802 had a related patch set uploaded by Florianschmidtwelzow:
WIP: Enable anonymous editing in alpha mode

https://gerrit.wikimedia.org/r/138802

Change 138802 merged by jenkins-bot:
Enable anonymous editing in alpha mode

https://gerrit.wikimedia.org/r/138802

Florian I just realised your patch doesn't address this issue. Can you fix that in a follow up asap as otherwise I suspect we will have to disable it on alpha.

https://gerrit.wikimedia.org/r/155306 temporarily reverts the patch. We can revert the revert when this bug is fixed.

I'll take a look on it.

We can revert the revert when this bug is fixed.

Or just add the lines in the fix? :)

Which fix? Is there another patch that fixes this?

I mean a future fix :) When we have some :P

Change 155312 had a related patch set uploaded by Florianschmidtwelzow:
Add intermediate screen for anonymous editors

https://gerrit.wikimedia.org/r/155312

Change 155312 merged by jenkins-bot:
Add intermediate screen for anonymous editors

https://gerrit.wikimedia.org/r/155312

Screen added, in alpha activated :)