Page MenuHomePhabricator

Must click TWICE to toggle between desktop and mobile
Closed, ResolvedPublic

Description

Author: jgonera

Description:

  • Open a private browser window.
  • Go to your local instance and click Mobile view.

The URL changes but the page stays in desktop mode. You have to manually refresh the page again. It's even worse on iOS where refreshing doesn't help, you have to go to the root URL again (http://127.0.0.1/).

Can't reproduce on enwiki.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63350

Details

Reference
bz61400

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz61400.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1708

Change 114392 had a related patch set uploaded by Awjrichards:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/114392

Change 114392 merged by jenkins-bot:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/114392

Patch is merged, should now be resolved in master.

We had to revert this change due to an edge-case production bug introduced (bug 62078). It should be trivial to resolve the problem but I need to consult with the Zero team about the change before implementing it, and no one is currently available so this will likely have to wait til next week to get resolved again.

Email noted now that on IRC. Reviewing...

Reverted again. I declare this bug cursed! Let's NOT fix it.

For the record, this change had to be reverted due to recursive errors. Reopening as we should probably work out what causes these recursive errors!

  • Bug 63348 has been marked as a duplicate of this bug. ***

Please fix soon. Major embarrassment on non-Wikimedia wikis!!

The perfect and instant solution would be for the "Mobile | Desktop"
links at the bottom of each page to link instead to just
useformat=mobile and useformat=desktop !!

I am not able to vote for this bug. You got to see it to believe it. http://abj.jidanni.org/ .
One might think of putting a siteNotice "Click twice to toggle moblie / desktop", but that's broken too, Bug 63457.

Maybe users can implement Comment 11 via some Hook as a workaround?

[Prioritization is done by the Mobile team hence reverting; for severity meanings see https://www.mediawiki.org/wiki/Bugzilla/Fields#Severity ]

Change 123678 had a related patch set uploaded by Awjrichards:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/123678

Change 123678 merged by jenkins-bot:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/123678

Just curious how soon should I expect to see it?

cd /home/jidanni/mediawiki/extensions
+ git pull
From https://gerrit.wikimedia.org/r/p/mediawiki/core

f1b45cb..49bc9d3  master     -> origin/master
74ccd34..f935b80  wmf/1.23wmf21 -> origin/wmf/1.23wmf21

Updating f1b45cb..49bc9d3
Fast-forward
includes/resourceloader/ResourceLoader.php | 59 ++++++++++++++++++++++---------------
resources/oojs-ui/i18n/zh-hans.json | 2 +-
resources/oojs-ui/oojs-ui-apex.css | 9 ++++--
resources/oojs-ui/oojs-ui.js | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
resources/oojs-ui/oojs-ui.svg.css | 4 +--
5 files changed, 154 insertions(+), 38 deletions(-)

(In reply to Dan Jacobson from comment #17)

Just curious how soon should I expect to see it?

https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap

I use https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MobileFrontend.git

So that means at exactly one week after

group 0 Thursday, 3 April 2014 MediaWiki.org; testwiki; test2wiki; testwikidatawiki

I can use git pull and that will contain the change?

If you are running your own MediaWiki install, yes simply pull down the latest code and you will have the fix instantly.