Page MenuHomePhabricator

Bad filename upload error
Closed, ResolvedPublic

Description

I recently experienced a bad filename error when I tried to upload a file via mobile. The description was "Cheatahs play a live show at Amoeba music"

This generated incorrectly a bad filename error. Any idea why?

Bad filename: [Cheatahs_play_a_live_show_at_Amoeba_music_2014-03-01_16-52.jpg]

User agent:
Mozilla/5.0 (Linux; Android 4.4.2; Nexus 4 Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.136 Mobile Safari/537.36↵


Version: unspecified
Severity: normal

Details

Reference
bz62241

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:58 AM
bzimport set Reference to bz62241.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1749

sure4us wrote:

I also consistently experienced this error on wmf16 install.

My text was:

Jellyfish. Taken at Ripley's aquarium in Toronto.


The progress bar began to upload, but reset at about 80% finished.

Note: Removing the second period allowed me to upload the file just fine.
User Agent: Iphone 4 - Safari

I can't reproduce this error. Can either of you provide steps to reproduce?

Maybe it's related to the TitleBlacklist extension. Investigating...

Here is the blacklist currently in effect for WMF projects:
https://meta.wikimedia.org/wiki/Title_blacklist

Could not reproduce while using TitleBlacklist extension with same blacklist as production wikis.

Change 122554 had a related patch set uploaded by Kaldari:
Adding debugging for bug 62241

https://gerrit.wikimedia.org/r/122554

Change 122554 merged by jenkins-bot:
Adding debugging for bug 62241

https://gerrit.wikimedia.org/r/122554

We still have to wait for this patch to get on to production. I've pushed the bug to the next iteration.

According to Max, when live we'll be able to go to https://logstash.wikimedia.org
and search for
type:upload

I can now replicate this issue consistently.
Go to a new article.
Click lead photo uploader
Paste the descriptions as (remove the quotation marks):
"double space woop woop "
The upload fails

Created attachment 15108
Various filename errors from the logs that helped us debug this

Attached:

Change 126115 had a related patch set uploaded by Jdlrobson:
Avoid file names with double spaces

https://gerrit.wikimedia.org/r/126115

Change 126115 merged by jenkins-bot:
Avoid file names with double spaces

https://gerrit.wikimedia.org/r/126115

Let's see if errors reduce after deployment before making this as fixed.

Okay so since code was merged on 15th it rode deployment train on 17th reaching all wikis by 24th

Since that day [1] there have been no badfilename errors whatsoever but various other errors. You can also see the upload error graph drop [2].

(Despite the EventLogging outage there are still errors being reported of other times)
Thus I think we are good.

upload/error/badtoken 34
upload/error/unknownerror 11
undefined/undefined 10
upload/error/http 9
upload/warning/duplicate-archive/This_is_the_person_the_page_is_describing_2014-04-01_17-53.jpg 7
upload/warning/exists/Wajah_polos_2014-04-26_05-28.jpg 5
upload/error/verification-error/filetype-mime-mismatch 4
edit/error/blocked 4
upload/warning/duplicate-archive/IM-A890.jpg 3
edit/error/editconflict 2
upload/warning/duplicate-archive/My_family_history_in_sweden--The_bad_moment_is_gone-_The_past_is_gone_for_me_and_my_family-_But_the_truth_must_be_spoken_and_deal_with_in_the_future-_If_you_w 2
upload/warning/duplicate-archive/Selim_koray_2014-02-03_02-19.jpg 1
upload/warning/bad-prefix/Imagen_del_Cristo_de_la_Vela,_perteneciente_a_la_Hermandad_del_Silencio_de_Salamanca,_en_su_procesión_del_Sábado_Santo_de_2014-_2014-04-27_10-35.jpg 1
upload/warning/exists/Rendition_of_of_official_Mechanikal_Element_logo_with_a_collage_of_artwork_from_past_events_in_the_background_2014-04-26_17-48.jpg 1
upload/warning/duplicate-archive/גילה_גולדשטיין_2014-04-22_03-04.jpg 1
upload/warning/exists/A_picture_of_rayn_tedder_-rayn_tedder_the_lead_singer_of_the_American_band_called_"ONEREPUBLIC"_2014-04-25_23-39.png 1
upload/warning/duplicate-archive/For_my_love_and_care_for_the_children_and_Adults_and_the_youth_and_families_in_the_world-_mothers_and_fathers_in_the_world-_Social_workers_and_governments_emp 1
upload/warning/exists/Lady_precious_raymond_2014-04-27_12-10.jpg 1
upload/warning/duplicate-archive/Heaven_2.jpg 1
upload/warning/duplicate-archive/Nba_Playoffs_2014-04-25_16-12.jpg 1
upload/warning/exists/Ein_Logo_der_Menschenrechtpartei_-MRP_2014-04-26_22-55.jpg 1
upload/warning/duplicate-archive/-my_business_information-I_am_an_artist_,_a_musician_by_profession-_I_am_a_hip_pop_artist_in_musician_and_Band-_as_well_as_a_music_lecturer_-_Facilitators_-_C 1

[1] select event_errorText, count(*) from MobileWebUploads_7967082 where event_action = 'error' and timestamp >= 20140425000000 group by event_errorText
[2] http://mobile-reportcard.wmflabs.org/graphs/error-uploads

Change 280082 had a related patch set uploaded (by Bartosz Dziewoński):
UploadBase: Remove debug logging for T64241

https://gerrit.wikimedia.org/r/280082

Change 280082 merged by jenkins-bot:
UploadBase: Remove debug logging for T64241

https://gerrit.wikimedia.org/r/280082

kaldari removed a subscriber: kaldari.Apr 1 2016, 3:55 PM