Page MenuHomePhabricator
Create Task
Maniphest T64651

basetimestamp parameter is broken? the edit was stored even with months old basetimestamp
Closed, InvalidPublic
Actions

Description

I was trying to edit some pages on tests wiki

https://test.wikipedia.org/w/index.php?title=User_talk:Petrb&action=history

I made edit at 17:41, 14 March 2014‎ Petrb (talk | contribs | block)

then I made edit again with &basetimestamp=2013-12-21T09%3A09%3A45Z and THIS EDIT DID PASS, even if the basetimestamp is several months old. How is it possible? Isn't this supposed to display some error? If not, how this parameter is supposed to work? Documentation say that.

Version: unspecified
Severity: major

Details

Reference
bz62651

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:51 AM
• bzimport added a project: MediaWiki-Action-API.
• bzimport set Reference to bz62651.
• bzimport added a subscriber: Unknown Object (MLST).
Petrb created this task.Mar 14 2014, 5:46 PM
Umherirrender added a comment.Mar 14 2014, 6:07 PM

The basetimestamp is used to detect edit conflicts. When the conflict is detected and can be resolved automatically than it is done, the same as editing with the gui.
Providing no basetimestamp will override all previous edits and will not merge they.

Anomie added a comment.Mar 14 2014, 6:09 PM

No, basetimestamp is not broken. Your edit conflict was automatically merged. You may want to look at the logic in EditPage.php near lines 1646-1671 to see just how it works (the value from basetimestamp is in $this->edittime).

BTW, it would be helpful in the future if you detail the exact API queries you made, rather than just saying "I made edits".

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits