Call the global disablePopups() if present
Description
Details
- Reference
- bz62952
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Disable Navigation Popups on render rather than document load | mediawiki/extensions/Popups | master | +8 -3 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Declined | None | T88882 Move Hovercards to OOjs and OOjs UI | |||
Resolved | None | T92555 Turn off 2 month test release of Hovercards on Catalan, and Greek Wikipedias on 2015-06-18 | |||
Resolved | • Tnegrin | T88164 Make hovercards default for Catalan and Greek Wikipedias for 2 months starting 2015-04-15 | |||
Duplicate | None | T88467 Start Hovercard reader trial (dupe) | |||
Resolved | • Prtksxna | T64952 Disable NavigationPopups (Gadget) if Hovercards Beta Feature is enabled |
Event Timeline
Change 120188 had a related patch set uploaded by Prtksxna:
Disable NavigationPopups (Gadget) is Popups (Extension) is enabled
Change 120188 merged by jenkins-bot:
Disable NavigationPopups (Gadget) if Popups (Extension) is enabled
Change 141668 had a related patch set uploaded by Prtksxna:
disablenavpop: Use winow:load instead of dom:ready
Change 141668 merged by jenkins-bot:
disablenavpop: Use winow onload instead of dom ready
Re-opening, as I'm getting Hovercards and Navpopups at the same time, at mediawiki.org. Firefox 32.
Also, the settings menu is only showing me options for "Simple" and "Disable previews", no matter what I try or change.
(Note: I removed navpopups from my global.js and that did Not fix either of the problems.)
I need help resolving this bug. I am unable to understand the order in which things are executing, though the order should not be affecting this at all.
The code in the Extension [1] and my common.js [2] are the same and yet it does not work from the extension. Any help is welcome.
[1] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/7b5fbab16011f1770f69248dd3e4d99bea7e4b4f/resources%2Fext.popups.disablenavpop.js
[2] https://en.wikipedia.org/wiki/User:Prtksxna/common.js
Hmm, yes this is a little bit complicated.. Nav Popups actually does several events, each of which are preceded by a setupPopups() check, which when not setup, happily sets up nav popups..
The only way i can see to counter this is simply disabling multiple times as well. It's not nice, but that's the only thing I can imagine.
Depending on how many copies of navpopups are out there, I could consider adding an 'explicit' disable flag, that gets checked by setupPopups before it starts doing it's job...
But non en.wiki copies would not benefit from that..
Change 183008 had a related patch set uploaded (by Prtksxna):
Disable Navigation Popups on render rather than document load
Change 183008 merged by jenkins-bot:
Disable Navigation Popups on render rather than document load