Page MenuHomePhabricator

Add Jenkins jobs for Popups extension repo
Closed, ResolvedPublic

Description

The Popups extension repo does not appear to have any Jenkins jobs yet. Please add them, as IMO it improves quality and awareness.


Version: wmf-deployment
Severity: normal

Details

Reference
bz62997

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz62997.
bzimport added a subscriber: Unknown Object (MLST).
siebrand created this task.Mar 24 2014, 7:15 AM

I just pushed some code, which didn't really fix any of those errors and its not failing - https://integration.wikimedia.org/ci/job/mwext-Popups-lint/2/console

Does this mean we can close this bug?

Its happening again https://integration.wikimedia.org/ci/job/mwext-Popups-jslint/7/console

These errors usually go away after a recheck do I need to edit a .jshint file?

Change 120752 had a related patch set uploaded by Prtksxna:
Add .jshintrc file

https://gerrit.wikimedia.org/r/120752

The jslint job is only triggered when Javascript related files are edited (.jshint*, *.js or *.json iirc).

Requiring an empty .jshintrc file is bug https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 :-D Should be fixed soon by making sure jshint always uses the defaults.

I've added a non-empty .jshintrc file. Once this patch gets merged we should be able to close this bug.

Change 120752 merged by jenkins-bot:
Add .jshintrc file and update core.js to remove errors

https://gerrit.wikimedia.org/r/120752