Re-consider font size and font-family for form elements in Vector
OpenPublic

Description

screenshot using firefox on windows showing upload wizard form inputs with font-sizes annotated

Currently, Upload Wizard defines font-family: sans-serif for most of its form elements. After the "typographical refresh", this, together with the slightly smaller font-family, produces a misaligned output.

https://commons.wikimedia.org/w/index.php?title=Commons%3AVillage_pump&diff=120509714&oldid=120505191


Attached:

bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz63408.
Rillke created this task.Via LegacyApr 2 2014, 11:19 AM
Rillke added a comment.Via ConduitApr 2 2014, 11:23 AM

Created attachment 15004
more drastically on ff/linux

Attached:

Aklapper added a comment.Via ConduitApr 2 2014, 12:01 PM

Thanks for taking the time to report this!

How does this create an accessibility problem (anybody could increase the font size in th browser)?

Rillke added a comment.Via ConduitApr 2 2014, 12:09 PM

(In reply to Andre Klapper from comment #2)

anybody could increase the font size in th browser

The aim of the "typographical refresh" refresh update was I think to not have people to fiddle around with their browser settings.

Rillke added a comment.Via ConduitApr 2 2014, 7:16 PM

yeah, form elements do not inherit font family from their offset parents, so you may start a separate bug for this, as if you like to add something similar to

input,select,textarea { font-family:inherit; font-size:inherit; }

but note that UpWiz explicitly defines sans-serif for some classes used on input elements in it.

Steinsplitter added a comment.Via ConduitApr 4 2014, 9:33 AM

It is fiexed now? It looks like no?
@Rillke: I guess we can fix this in the global .ccs?

Rillke added a comment.Via ConduitApr 4 2014, 8:14 PM

(In reply to Steinsplitter from comment #5)
Why is this a major issue? The text is still readable by most people. Or does it even look worse for you than the screenshots I attached?

Yes, we could attempt to "fix" it but applying extra-css often causes many side effects and I'd really like to see it fixed by someone running browser tests before or having a very good understanding of what could happen. Leaving the side effects aside, there is still the maintenance issue. The code we have must be probably be updated if the TypoRefresh updates. No, please let users complain and nag here instead.

Jaredzimmerman-WMF added a comment.Via ConduitApr 9 2014, 6:49 PM

Sounds like the fix for this is removing extra overrides from this form.

Gilles added a project: Multimedia.Via WebNov 24 2014, 3:33 PM
Krinkle edited the task description. (Show Details)Via WebJan 5 2015, 2:12 AM
Krinkle set Security to None.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.