Page MenuHomePhabricator

Tab from Username no longer sends user to Password field, but instead to Search box
Closed, ResolvedPublic

Description

Seen in both beta labs and mw.o but not yet in enwiki:

Go to login screen.
Type Username
hit TAB button

cursor goes to Search box

cursor should go to Password box


Version: unspecified
Severity: blocker
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=29199

Details

Reference
bz65704

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:19 AM
bzimport set Reference to bz65704.

swalling wrote:

Confirmed that I get this on mediawiki.org for both account creation and login. This is bizarre. I don't think we changed the tabindex? Maybe it has something to do with the new search?

(In reply to Steven Walling from comment #1)

I don't think we changed the tabindex?

Bug 29199 comment 21 got committed; more stuff cooking in bug 46336.

Marking a blocker, because this can leaks a password into the search field when using the same workflow as before, which is the better one.
Please find a solution before deployment to more wikis. Thanks.

gerrit 134801 was the corresponding change set

Change 135205 had a related patch set uploaded by Mattflaschen:
Revert "Restore search box tabindex"

https://gerrit.wikimedia.org/r/135205

Change 135205 merged by jenkins-bot:
Revert "Restore search box tabindex"

https://gerrit.wikimedia.org/r/135205

Change 135208 had a related patch set uploaded by Mattflaschen:
Revert "Restore search box tabindex"

https://gerrit.wikimedia.org/r/135208

Change 135269 had a related patch set uploaded by Mattflaschen:
Fix search box tabindex again

https://gerrit.wikimedia.org/r/135269

Fixed in master, pending WMF backport.

Change 135208 merged by Reedy:
Revert "Restore search box tabindex"

https://gerrit.wikimedia.org/r/135208

greg added a comment.May 27 2014, 10:35 PM

To be explicit:
The cause of this has been reverted in the production branches (https://gerrit.wikimedia.org/r/135208), but there is sitll discussion about the correct way forward (https://gerrit.wikimedia.org/r/135269).

FYI: We'll need to either come to a conclusion on that second one by Thursday morning Pacific time, or simply revert the code that was reverted in the first one in master (so that we don't have to keep re-reverting it in the wmfXX branches, which is prone for error).

Assigning to Alex as it's his patch that is being reviewed now.

(In reply to Greg Grossmeier from comment #10)

To be explicit:
The cause of this has been reverted in the production branches
(https://gerrit.wikimedia.org/r/135208), but there is sitll discussion about
the correct way forward (https://gerrit.wikimedia.org/r/135269).

I reverted it in master first Saturday, and it was merged very shortly thereafter the same day. See https://gerrit.wikimedia.org/r/#/q/Iaea60834aa8f1564aca50c21ee62ae01f958cc65,n,z

FYI: We'll need to either come to a conclusion on that second one by
Thursday morning Pacific time, or simply revert the code that was reverted
in the first one in master (so that we don't have to keep re-reverting it in
the wmfXX branches, which is prone for error).

For this reason (among others), my understanding that the general rule (with rare exceptions) is that it should be merged to master before being cherry-picked.

Also, this part is fixed. It's the search box that is being worked on again (covered under bug 29199, though maybe it should get a dedicated bug).

[Backport was merged into 1.24wmf6 once upon a time, hence setting Backport_WMF flag to +]