Page MenuHomePhabricator
Create Task
Maniphest T69989

[jquery.tipsy] Uses deprecated $.fn.live when using live option
Closed, ResolvedPublic
Actions

Description

Original bug title:
[jquery.tipsy] Uses deprecated $.fn.live when using live option

Minimal test case:

mw.loader.using( 'jquery.tipsy', function() {
	$( 'a' ).tipsy( {
		live: true
	} );
} );

Evidence:
https://phabricator.wikimedia.org/diffusion/MW/browse/master/resources/src/jquery.tipsy/jquery.tipsy.js;dcdca4944dec1228b6ca38955298c8a541f01378$186

var binder = options.live ? 'live' : 'bind',
	eventIn = options.trigger == 'hover' ? 'mouseenter' : 'focus',
	eventOut = options.trigger == 'hover' ? 'mouseleave' : 'blur';
this[ binder ]( eventIn, enter )[ binder ]( eventOut, leave );

Expected:
Work around according to http://api.jquery.com/live/

See T85048: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features

Version: 1.24rc
Severity: normal

Details

Reference
bz67989
SubjectRepoBranchLines +/-
jquery.tipsy: Unbreak the 'live' option for nowmediawiki/corewmf/1.25wmf13+17 -6
jquery.tipsy: Unbreak the 'live' option for nowmediawiki/corewmf/1.25wmf12+17 -6
jquery.tipsy: Unbreak the 'live' option for nowmediawiki/coremaster+17 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:29 AM
• bzimport added a project: MediaWiki-JavaScript.
• bzimport set Reference to bz67989.
• bzimport added a subscriber: Unknown Object (MLST).
Rillke created this task.Jul 14 2014, 2:38 PM
matmarex merged a task: T76272: jquery.tipsy broken.Nov 30 2014, 3:54 PM
matmarex updated the task description. (Show Details)
matmarex set Security to None.
matmarex added a subscriber: alex-mashin.
matmarex removed a subscriber: Unknown Object (MLST).
Krinkle raised the priority of this task from Medium to High.Dec 10 2014, 1:40 PM
Krinkle added a project: Technical-Debt.

jQuery migration has been finalised as of last week. If this wasn't addressed, it most likely broken now.

Rillke added a comment.Dec 16 2014, 10:04 PM

Confirmed, it is. Throwing JS errors making my tools dysfunct.

this[binder] is not a function

$.fn.tipsy@https://bits.wikimedia.org/static-1.25wmf12/resources/src/jquery.tipsy/jquery.tipsy.js:189:13
Rillke added a comment.Dec 17 2014, 3:47 PM

Added the following snippet to my affected tools:

// https://phabricator.wikimedia.org/T69989
// http://code.jquery.com/jquery-migrate-1.2.1.js
jQuery.fn.live = function( types, data, fn ) {
	jQuery( this.context ).on( types, this.selector, data, fn );
	return this;
};
matmarex claimed this task.Dec 19 2014, 11:58 PM
gerritbot added a project: Patch-For-Review.Dec 20 2014, 12:18 AM

Change 181216 had a related patch set uploaded (by Bartosz Dziewoński):
jquery.tipsy: Unbreak the 'live' option for now

https://gerrit.wikimedia.org/r/181216

Patch-For-Review

matmarex updated the task description. (Show Details)Dec 20 2014, 1:39 AM
gerritbot added a comment.Dec 20 2014, 2:04 AM

Change 181216 merged by jenkins-bot:
jquery.tipsy: Unbreak the 'live' option for now

https://gerrit.wikimedia.org/r/181216

• Mattflaschen-WMF mentioned this in rMWaa524075ac73: jquery.tipsy: Unbreak the 'live' option for now.Dec 20 2014, 2:04 AM
gerritbot added a comment.Dec 20 2014, 2:24 AM

Change 181228 had a related patch set uploaded (by Mattflaschen):
jquery.tipsy: Unbreak the 'live' option for now

https://gerrit.wikimedia.org/r/181228

Patch-For-Review

gerritbot added a comment.Dec 20 2014, 2:25 AM

Change 181229 had a related patch set uploaded (by Mattflaschen):
jquery.tipsy: Unbreak the 'live' option for now

https://gerrit.wikimedia.org/r/181229

Patch-For-Review

• Mattflaschen-WMF closed this task as Resolved.Dec 20 2014, 2:28 AM
• Mattflaschen-WMF mentioned this in T85048: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF subscribed.

Fixed but see T85048: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features.

gerritbot added a comment.Dec 20 2014, 2:35 AM

Change 181228 merged by Mattflaschen:
jquery.tipsy: Unbreak the 'live' option for now

https://gerrit.wikimedia.org/r/181228

• Mattflaschen-WMF mentioned this in rMW170d34ee5e00: jquery.tipsy: Unbreak the 'live' option for now.Dec 20 2014, 2:36 AM
gerritbot added a comment.Dec 20 2014, 2:36 AM

Change 181229 merged by Mattflaschen:
jquery.tipsy: Unbreak the 'live' option for now

https://gerrit.wikimedia.org/r/181229

• Mattflaschen-WMF mentioned this in rMWe328b5b59acd: jquery.tipsy: Unbreak the 'live' option for now.Dec 20 2014, 2:36 AM
RandomDSdevel awarded a token.Jan 12 2015, 11:58 PM
matmarex added a comment.Jul 25 2016, 11:43 AM

I have submitted a patch for discussion at T85048: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features which removes this workaround.

Tacsipacsi updated the task description. (Show Details)Dec 4 2016, 9:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits