Make VisualEditor transaction processing exception-safe
Closed, ResolvedPublic40 Estimated Story Points
Actions

Description

If an exception occurs while processing a transaction, we should roll it back safely, so the converter will still work and the user can still save or bail to source mode.

Version: unspecified
Severity: enhancement

Details

Reference: bz68892

	Subject	Repo	Branch	Lines +/-
	Make transaction processing exception-safe	VisualEditor/VisualEditor	master	+122 -25

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T196211 Deploy CollabPad to officewiki
Open	None	T76548 Provide real-time collaboration in VisualEditor-MediaWiki
Open	None	T76546 Provide real-time collaborative editing in VisualEditor
Resolved	• Catrope	T68229 VisualEditor: Would be nice if copying/pasting kept working after a fatal
Resolved	• Catrope	T70892 Make VisualEditor transaction processing exception-safe

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:38 AM

• bzimport added projects: VE-deploy-nextup, VisualEditor-DataModel.

• bzimport set Reference to bz68892.

• Catrope created this task.Jul 31 2014, 1:08 AM

Change 152776 had a related patch set uploaded by Jforrester:
Queue up annotation changes to make operations safer

https://gerrit.wikimedia.org/r/152776

Change 152776 merged by jenkins-bot:
Queue up annotation changes to make operations safer

https://gerrit.wikimedia.org/r/152776

Operations are now queued but exceptions aren't caught yet.

Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:48 PM

Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.Nov 23 2014, 10:59 PM

Jdforrester-WMF removed a project: VE-deploy-nextup.Nov 24 2014, 10:02 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Feb 2 2015, 7:56 PM

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF raised the priority of this task from Medium to High.Feb 3 2015, 5:05 PM

Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.

• TrevorParscal edited a custom field.Feb 4 2015, 7:14 PM

Jdforrester-WMF reassigned this task from Esanders to • Catrope.Mar 4 2015, 10:08 PM

Change 195361 had a related patch set uploaded (by Catrope):
Make transaction processing exception-safe

https://gerrit.wikimedia.org/r/195361

gerritbot added a project: Patch-For-Review.Mar 9 2015, 8:32 PM

Jdforrester-WMF renamed this task from VisualEditor: Make transaction processing exception-safe to Make VisualEditor transaction processing exception-safe.Mar 10 2015, 4:42 PM

Jdforrester-WMF closed this task as Resolved.

Jdforrester-WMF edited projects, added WMF-deploy-2015-03-11_(1.25wmf21); removed Patch-For-Review.

Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.

Change 195361 merged by jenkins-bot:
Make transaction processing exception-safe

https://gerrit.wikimedia.org/r/195361

• Catrope mentioned this in rGVED04e7b17f4896: Make transaction processing exception-safe.Mar 10 2015, 4:44 PM

Jdforrester-WMF moved this task from Planned Maintenance to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 10 2015, 8:09 PM