Wikibase is an extension, and should have a wikibase.py instead of being in page.py and site.py
We already keep the tests in wikibase_tests.py.
URL: http://comments.gmane.org/gmane.comp.python.pywikipediabot.general/13886
Related tasks:
T108440: Pull out all Wikibase-related parts of pywikibot to pywikibot/wikibase and use it as a submodule
T112236: Extensible package design
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Move Wikibase-specific code into wikibase.py | pywikibot/core | master | +1 K -1 K |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Xqt | T70898 Move Wikibase specific code out of page.py and site.py | |||
| Declined | None | T112236 Extensible package design | |||
| Open | None | T247238 Move wikibase stuff to a separate file/module |
Can we please work on getting the existing patches committed before the split.
We should delay new major patches until after the split.
Change 182407 had a related patch set uploaded (by Ricordisamoa):
Move Wikibase-specific code into wikibase.py
Change 182407 abandoned by Ricordisamoa:
Move Wikibase-specific code into wikibase.py
Reason:
We have now pywikibot/wikibase
I am strictly against splitting main parts of the framework out of the current project. On bot owner side it is more difficult to combine a working bot, on developers side it is more difficult to check the code when it is distributed on several parts.