Page MenuHomePhabricator

makecat does not work with command line arguments
Closed, ResolvedPublic

Description

When the category name is put on the command line in Linux

$ python pwb.py scripts/makecat.py -family:wikipedia -lang:en Roads_in_Kent
Traceback (most recent call last):

File "pwb.py", line 157, in <module>
  run_python_file(fn, argv, argvu)
File "pwb.py", line 67, in run_python_file
  exec(compile(source, filename, "exec"), main_mod.__dict__)
File "scripts/makecat.py", line 217, in <module>
  workingcatname = unicode(workingcatname, 'utf-8')

TypeError: decoding Unicode is not supported
<type 'exceptions.TypeError'>
CRITICAL: Waiting for 1 network thread(s) to finish. Press ctrl-c to abort

It works correctly if the category name is entered via pywikibot.input()

$ python pwb.py scripts/makecat.py -family:wikipedia -lang:en
Which page to start with? Roads_in_Kent

WARNING: unicode.setAction is DEPRECATED, use comment parameter for page saving method instead. Retrieving 32 pages from wikipedia:en. Retrieving 50 pages from wikipedia:en.

Roy Phippen

....


Version: core-(2.0)
Severity: major
OS: Linux
Platform: PC

Details

Reference
bz69060

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:31 AM
bzimport set Reference to bz69060.
bzimport added a subscriber: Unknown Object (????).
jayvdb created this task.Aug 3 2014, 2:57 AM
jayvdb added a comment.Aug 3 2014, 2:58 AM

Im guessing the 'unicode(workingcatname, 'utf-8')' was put in there for a reason; probably some other issue wrt pywikibot.input or command line argument handling.

jayvdb added a comment.Aug 3 2014, 3:56 AM

I see it wasnt using pywikibot.input, which is why casting to unicode was needed.

https://gerrit.wikimedia.org/r/#/c/151375/3