Page MenuHomePhabricator
Create Task
Maniphest T71068

split test suite into tests which depend on a server, and those that do not
Closed, ResolvedPublic
Actions

Description

After a discussion with Legoktm and hashar about jenkins running tests on bug 50344 and IRC, the first step is to run tests which do not depend on a mediawiki site.

Version: core-(2.0)
Severity: enhancement

Details

Reference
bz69068

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT52344 Set up unit test running for pywikibot/core
 ResolvedjayvdbT71068 split test suite into tests which depend on a server, and those that do not
 ResolvedXqtT71069 Scripts which are not properly tested by script_tests (tracking)
 ResolvedNoneT73864 Travis builds not loading flickrripper due to missing ImageTk
 ResolvedNoneT62042 Problem with uploading files
 ResolvedNoneT70645 pywikibot.ui.editText imports gui which does not exist in core
 ResolvedNoneT70606 flickrripper doesnt compile as it depends on config.flickr which is not defined
 ResolvedjayvdbT70611 Running data_ingestion.py depends on tests/data/csv_ingestion.csv
 ResolvedGeorggi1999T70613 checkimages.py reports execution time even when the bot does not execute
 ResolvedNoneT70657 claimit without arguments has no output
 ResolvedNoneT70658 imagerecat fails on attempting to process any page
 ResolvedRicordisamoaT70661 template.py without arguments has no output
 ResolvedNoneT70660 pagefromfile OS error when no parameters provided
 ResolvedNoneT70662 transferbot raises ugly exception if zero cmd line arguments are given
 ResolvedNoneT70663 misspelling doesnt quit on user input 'q'
 ResolvedmurfelT70664 replicate_wiki doesnt support help or other global command line options
 ResolvedMpaaT70665 misspelling breaks when script is not configured for the site
 ResolvedLadsgroupT70797 script_wui hardcoded to use User:DrTrigon
 ResolvedXZiseT71015 cfd assumes family wikipedia
 ResolvedNoneT71039 welcome raises TypeError exception if site is not configured
 ResolvedNoneT71060 makecat does not work with command line arguments
 ResolvedNoneT71062 makecat exception when nothing is entered into first prompt
 ResolvedRicordisamoaT71089 lonelypages.py throws Exception if not configured for the site
 ResolvedRicordisamoaT71091 add_text.py and commonscat.py report NoEnoughData to user
 ResolvedXqtT70153 blockpageschecker.py fails on English Wikipedia
 ResolvedXqtT193972 Missing unittests for version.py script
 ResolvedXqtT193973 Missing unittests for imageharvest.py
 DeclinedNoneT193974 Missing unittests for script_wui.py
 ResolvedNoneT95384 errors in script tests
 ResolvedXqtT95372 Random failure because of unexpected success in catall
 ResolvedXqtT95385 welcome -simulate returns 1 when timeout occures
 ResolvedXZiseT96615 ar.wikt unusedfiles -simulate fails
 ResolvedXqtT128955 script test for featured.py fails
 ResolvedXqtT128453 script_tests fails for editarticle in windows environment
 ResolvedXqtT167726 test_imageharvest breaks tests
 DeclinedBUG REPORTNoneT223211 cfd.py throws an error after few seconds
 ResolvedBUG REPORTXqtT223487 nowcommons.py throws an error on enwiki

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:31 AM
• bzimport added a project: Pywikibot-tests.
• bzimport set Reference to bz69068.
jayvdb created this task.Aug 3 2014, 11:21 AM
jayvdb added a comment.Aug 3 2014, 11:33 AM

Running the scripts with -help should be possible without a working connection to the server, providing basic code coverage.

jayvdb added a comment.Aug 4 2014, 10:19 AM

https://gerrit.wikimedia.org/r/#/c/151604/

hashar added a comment.Aug 19 2014, 2:12 PM

The patch has been merged. Tests hitting sites have a 'site' attribute and the ones in need of network access a 'net' attribute.

For the record:

https://gerrit.wikimedia.org/r/#/c/151604/ brings all the attribute logic, adds 'site' and filter tests to not run them (nosetests -a '!site').

https://gerrit.wikimedia.org/r/#/c/152276/ flagged httplib tests with 'net' and have them filtered out.

Thank you John!

Aklapper added a project: Pywikibot.Nov 27 2014, 4:15 PM
Xqt closed subtask T71069: Scripts which are not properly tested by script_tests (tracking) as Resolved.Sep 27 2020, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL