Page MenuHomePhabricator

ar.wikt unusedfiles -simulate fails
Closed, ResolvedPublic

Description

FAIL: Test running unusedfiles -simulate.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/jayvdb/pywikibot-core/tests/script_tests.py", line 293, in testScript
    self.assertIsNone(result['stdout'])
nose.proxy.AssertionError: "Working on 'ملف:666839.png'\n" is not None
-------------------- >> begin captured stdout << ---------------------
 killed   auto-run script stderr within 5 seconds: 'Retrieving 1 pages from wiktionary:ar.\n@@ -1 +1,3 @@\n- For local use at [[Mediawiki:Vector.css]] ***\n+ For local use at [[Mediawiki:Vector.css]] ***\n+  ***\n+ {{immagine orfana}} ***\n ***\nComment: صور للاستبعاد\nDo you want to accept these changes? ([y]es, [N]o, [a]ll, [q]uit): '  
--------------------- >> end captured stdout << ----------------------
-------------------- >> begin captured logging << --------------------
pywiki: VERBOSE: START /home/travis/build/jayvdb/pywikibot-core/tests/script_tests.py:TestScript.test_unusedfiles_simulate
pywiki: VERBOSE: END /home/travis/build/jayvdb/pywikibot-core/tests/script_tests.py:TestScript.test_unusedfiles_simulate NOT OK: FAILURE
--------------------- >> end captured logging << ---------------------

Event Timeline

jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Pywikibot-tests, Pywikibot.
jayvdb added subscribers: Unknown Object (MLST), jayvdb, Aklapper.
jayvdb triaged this task as Unbreak Now! priority.Apr 20 2015, 9:19 PM

It is marked as an autorun script, but these fail on the main builds because nosetests doesnt honour the PYWIKIBOT2_TEST_AUTORUN flag

Change 205458 had a related patch set uploaded (by XZise):
[FIX] script tests: Expect stdout text

https://gerrit.wikimedia.org/r/205458

Change 205458 merged by jenkins-bot:
[FIX] script tests: Expect stdout text

https://gerrit.wikimedia.org/r/205458

@jayvdb , @XZise: Patch has been merged - what is left to do here?
Can this be closed as resolved or is more work needed?
(Asking as this has "Unbreak now" priority.)

XZise claimed this task.
XZise lowered the priority of this task from Unbreak Now! to Needs Triage.
XZise removed a project: Patch-For-Review.
XZise set Security to None.