Page MenuHomePhabricator

flickrripper doesnt compile as it depends on config.flickr which is not defined
Closed, ResolvedPublic

Description

flickrripper.py fails to compile

Traceback (most recent call last):

File "pwb.py", line 157, in <module>
  run_python_file(fn, argv, argvu)
File "pwb.py", line 67, in run_python_file
  exec(compile(source, filename, "exec"), main_mod.__dict__)
File "scripts/flickrripper.py", line 631, in <module>
  main()
File "scripts/flickrripper.py", line 511, in main
  if not config.flickr['api_key']:

AttributeError: 'module' object has no attribute 'flickr'


Version: core-(2.0)
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=71864

Details

Reference
bz68606

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:36 AM
bzimport set Reference to bz68606.
bzimport added a subscriber: Unknown Object (????).
jayvdb created this task.Jul 26 2014, 6:17 AM

Change 151998 had a related patch set uploaded by Audiodude:
flickrripper.py: Protect the import of flickrapi with a try block.

https://gerrit.wikimedia.org/r/151998

Change 151998 merged by jenkins-bot:
flickrripper.py: Protect the import of flickrapi with a try block.

https://gerrit.wikimedia.org/r/151998

That changeset didn't fix this bug; but it did clean up an import error, and improve code comment syntax.

Change 170646 had a related patch set uploaded by John Vandenberg:
Add default config for flickrripper

https://gerrit.wikimedia.org/r/170646

Change 170646 merged by jenkins-bot:
Add default config for flickrripper

https://gerrit.wikimedia.org/r/170646