ar.wikt has only recently been added as a travis build host, and welcome -simulate is returning 1 unexpectedly in many of the initial builds
Occurs in all builds in https://travis-ci.org/wikimedia/pywikibot-core/builds/57584855
Occurs twice in https://travis-ci.org/wikimedia/pywikibot-core/builds/57574308 - py3.3 and py2.6
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T52344 Set up unit test running for pywikibot/core | |||
| Resolved | jayvdb | T71068 split test suite into tests which depend on a server, and those that do not | |||
| Invalid | None | T72936 Important tasks to be solved (tracking) | |||
| Resolved | Xqt | T193968 Missing unittests for scripts (tracking) | |||
| Resolved | Xqt | T71069 Scripts which are not properly tested by script_tests (tracking) | |||
| Resolved | None | T95384 errors in script tests | |||
| Resolved | Xqt | T95385 welcome -simulate returns 1 when timeout occures |
two more builds with seemingly random errors.
https://travis-ci.org/wikimedia/pywikibot-core/builds/57590123
https://travis-ci.org/wikimedia/pywikibot-core/builds/57592345
Still occurring after T95921
Only on ar.wikt again:
https://travis-ci.org/wikimedia/pywikibot-core/jobs/59086987
https://travis-ci.org/wikimedia/pywikibot-core/jobs/59087227
Change 179456 had a related patch set uploaded (by John Vandenberg):
Allow any autorun script to fail
As this has "Unbreak now" priority, could @jayvdb 's patch in https://gerrit.wikimedia.org/r/179456 please get reviewed/merged?
Change 207112 had a related patch set uploaded (by XZise):
nosetests does not honour PYWIKIBOT2_TEST_AUTORUN
Change 207112 merged by jenkins-bot:
nosetests does not honour PYWIKIBOT2_TEST_AUTORUN
Change 179456 abandoned by John Vandenberg:
nosetests does not honour PYWIKIBOT2_TEST_AUTORUN
Reason:
another approach has landed to do the job.
I don't know where @jayvdb wants to go with this. The original problem has been “solved” by just not executing the tests. But others could comment that it should be handled properly.
The problem still exists, but doesnt have an impact on the builds, or a large impact on users as there are no complaints and we cant seem to spot the problematic code.
The related problem is given with Python 2:
auto-run script unresponsive after 5 seconds FAIL
======================================================================
FAIL: test_welcome (tests.script_tests.TestScriptSimulate)
Test running welcome -simulate.
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\pwb\GIT\core\tests\script_tests.py", line 310, in testScript
self.assertIn(result['exit_code'], exit_codes)
AssertionError: 1 not found in [0, -9]
----------------------------------------------------------------------
Ran 4 tests in 9.647s
FAILED (failures=1)Unfortunately the test fails with TimeoutExpired with Python 3(.8)
======================================================================
ERROR: test_welcome (tests.script_tests.TestScriptSimulate)
Test running welcome -simulate.
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\pwb\GIT\core\tests\script_tests.py", line 243, in testScript
result = execute_pwb(cmd, data_in, timeout=timeout,
File "C:\pwb\GIT\core\tests\utils.py", line 699, in execute_pwb
return execute(command=command + args,
File "C:\pwb\GIT\core\tests\utils.py", line 672, in execute
stdout_data, stderr_data = p.communicate(timeout=timeout)
File "C:\Python38\lib\subprocess.py", line 1024, in communicate
stdout, stderr = self._communicate(input, endtime, timeout)
File "C:\Python38\lib\subprocess.py", line 1397, in _communicate
raise TimeoutExpired(self.args, orig_timeout)
subprocess.TimeoutExpired: Command '['C:\\Python38\\python.exe', 'C:\\pwb\\GIT\\core\\pwb.py', 'welcome', '-simulate']' timed out after 5 seconds
----------------------------------------------------------------------
Ran 4 tests in 9.090sChange 588001 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix subprocess results in Python 3
Change 588001 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix subprocess results in Python 3