Page MenuHomePhabricator
Create Task
Maniphest T72504

Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links
Closed, ResolvedPublic
Actions

Description

Create a link to [[bugzilla:12345]] and the link inspector thinks it's a redlink. Not great. :-(

Version: unspecified
Severity: minor

Details

Reference
bz70504
SubjectRepoBranchLines +/-
Actually perform interwiki check in MWLinkTargetInputWidgetmediawiki/extensions/VisualEditormaster+4 -1
Mark interwiki links as known in LinkTargetInputWidgetmediawiki/extensions/VisualEditormaster+39 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:55 AM
• bzimport added projects: VE-deploy-nextup, VisualEditor-MediaWiki.
• bzimport set Reference to bz70504.
Jdforrester-WMF created this task.Sep 7 2014, 2:56 AM
• bzimport added a comment.Sep 12 2014, 11:07 PM

gerritadmin wrote:

Change 160155 had a related patch set uploaded by Alex Monk:
Try to handle interwiki links in LinkTargetInputWidget

https://gerrit.wikimedia.org/r/160155

Krenair added a comment.Sep 17 2014, 12:08 AM

So it turns out this patch is basically useless because iw_api is barely populated anywhere. The MW installer doesn't do it (bug 46992), and WMF sites don't do it (maybe we should file a bug for this). Clever past-me filled the value for 'wikipedia' on my own install (which I what I had been testing against) and left it at that.

• bzimport added a comment.Sep 17 2014, 12:09 AM

gerritadmin wrote:

Change 160155 abandoned by Alex Monk:
Try to handle interwiki links in LinkTargetInputWidget

Reason:
Pretty much depends on upstream MediaWiki core + Wikimedia interwiki cache work, see bug for info

https://gerrit.wikimedia.org/r/160155

Jdforrester-WMF renamed this task from VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links to Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links.Nov 23 2014, 11:14 PM
Jdforrester-WMF added a project: VisualEditor.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Jdforrester-WMF removed a project: VE-deploy-nextup.Nov 24 2014, 10:02 PM
Krenair claimed this task.Dec 24 2014, 1:09 AM

I looked at this again and remembered that MW does nothing clever with interwiki titles. It does not try to check existence of interwiki titles. We should just be able to check to see if something is an interwiki title, and if so assume it exists.

Krenair removed a subtask: T48992: Fill the iw_api column of the interwiki table.Dec 24 2014, 1:16 AM
Krenair added a comment.Dec 24 2014, 1:18 AM

https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/Title.php;HEAD$4284

Also, from that it looks like extensions can just decide that some titles are always blue, and VE can't do much about this without a server-side check.

Krenair mentioned this in T72123: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly).Dec 25 2014, 8:05 PM
gerritbot added a project: Patch-For-Review.Jan 6 2015, 2:14 AM

Change 182988 had a related patch set uploaded (by Alex Monk):
Mark interwiki links as known in LinkTargetInputWidget

https://gerrit.wikimedia.org/r/182988

Patch-For-Review

Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Jan 6 2015, 5:59 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 16 2015, 7:17 PM
gerritbot subscribed.Jan 16 2015, 7:18 PM

Change 182988 merged by jenkins-bot:
Mark interwiki links as known in LinkTargetInputWidget

https://gerrit.wikimedia.org/r/182988

Krenair mentioned this in rEVEDe2fa665333e3: Mark interwiki links as known in LinkTargetInputWidget.Jan 16 2015, 7:19 PM
Jdforrester-WMF added a comment.Jan 18 2015, 5:30 PM

So now "Wikipedia:thispagedoesnotexist" always returns as a matching page in the suggestions list. :-(

Krenair added a comment.Jan 19 2015, 10:43 PM

Oh! Okay, yeah, there's a kind of crucial part missing. Will patch.

gerritbot added a comment.Jan 19 2015, 10:52 PM

Change 185925 had a related patch set uploaded (by Alex Monk):
Actually perform interwiki check in MWLinkTargetInputWidget

https://gerrit.wikimedia.org/r/185925

Patch-For-Review

gerritbot added a comment.Jan 20 2015, 1:04 AM

Change 185925 merged by jenkins-bot:
Actually perform interwiki check in MWLinkTargetInputWidget

https://gerrit.wikimedia.org/r/185925

Krenair mentioned this in rEVEDf0f2912c9de6: Actually perform interwiki check in MWLinkTargetInputWidget.Jan 20 2015, 1:04 AM
Jdforrester-WMF closed this task as Resolved.Jan 23 2015, 9:55 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-02-04_(1.25wmf16); removed Patch-For-Review.
Etonkovidova subscribed.Jan 29 2015, 7:25 PM

Verified in beta.

Etonkovidova added a project: Verified-in-Phase0.Feb 6 2015, 4:51 PM
Etonkovidova added a project: Verified-in-Phase2.Feb 13 2015, 1:03 AM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Aug 5 2015, 12:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL