Page MenuHomePhabricator
Create Task
Maniphest T72715

AbuseFilter doesn't log creating redirects in mainspace
Closed, ResolvedPublic
Actions

Description

It works in other namespaces d:Special:AbuseLog/428942 and also in all namespaces but only if you examine old revisions[1]

[1] https://www.wikidata.org/w/index.php?title=Special:AbuseFilter/examine/157156654&testfilter=%22%23REDIRECT%22+in+new_wikitext+%26+%21%28%22%23REDIRECT%22+in+old_wikitext%29

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0

Details

Reference
bz70715
SubjectRepoBranchLines +/-
Run EditFilterHooks in RedirectCreationInteractormediawiki/extensions/Wikibasemaster+251 -57
Implement EditFilterHookRunnermediawiki/extensions/Wikibasemaster+392 -121
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:52 AM
• bzimport added projects: MediaWiki-extensions-WikibaseRepository, patch-welcome.
• bzimport set Reference to bz70715.
• bzimport added a subscriber: Unknown Object (MLST).
matej_suchanek created this task.Sep 11 2014, 2:08 PM
Vogone added a comment.Sep 11 2014, 4:58 PM

Isn't this rather a bug with the AbuseFilter extension than with the WikidataRepo?

whym added a comment.Sep 18 2014, 8:45 AM

When you test the filter with "Examine past edits", it will match as expected. As Lymantria guessed [1], this might be due to the approach of using API for creating item redirects on Wikidata.

[1] https://www.wikidata.org/w/index.php?title=Wikidata:Contact_the_development_team&oldid=158155331#AbuseFilter_and_redirects

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:38 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher raised the priority of this task from Medium to High.Dec 3 2014, 8:04 PM
Lydia_Pintscher set Security to None.
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.Dec 27 2014, 4:15 PM
matej_suchanek updated the task description. (Show Details)Dec 28 2014, 8:17 PM
matej_suchanek added a project: AbuseFilter.
Addshore subscribed.Feb 17 2015, 4:01 PM

This seems to be tripping up both https://test.wikidata.org/wiki/Special:AbuseFilter/7 and https://www.wikidata.org/wiki/Special:AbuseFilter/60

Addshore awarded a token.Feb 17 2015, 4:02 PM
Addshore added a comment.Feb 17 2015, 4:24 PM

So EditEntity has a method runEditFilterHooks which it called from attemptSave and calls the EditFilterMergedContent hook.
RedirectCreationInteractor does not call this hook in its saveRedirect method.
I guess a call to this hook must be added!!

Lydia_Pintscher raised the priority of this task from High to Unbreak Now!.Feb 17 2015, 4:31 PM
Lydia_Pintscher lowered the priority of this task from Unbreak Now! to Needs Triage.
Lydia_Pintscher triaged this task as High priority.
Lydia_Pintscher moved this task from needs discussion or investigation to ready to go on the Wikidata board.
Addshore claimed this task.Apr 17 2015, 3:41 PM
gerritbot subscribed.Apr 17 2015, 3:59 PM

Change 204768 had a related patch set uploaded (by Addshore):
Implement EditFilterHookRunner

https://gerrit.wikimedia.org/r/204768

gerritbot added a project: Patch-For-Review.Apr 17 2015, 3:59 PM

Change 204790 had a related patch set uploaded (by Addshore):
Run EditFilterHooks in RedirectCreationInteractor

https://gerrit.wikimedia.org/r/204790

Addshore added a project: Wikidata-Sprint-2015-04-07.Apr 18 2015, 10:36 AM
Addshore moved this task from Backlog to Review on the Wikidata-Sprint-2015-04-07 board.
gerritbot added a comment.Apr 18 2015, 12:56 PM

Change 204768 merged by jenkins-bot:
Implement EditFilterHookRunner

https://gerrit.wikimedia.org/r/204768

Addshore mentioned this in rEWBAfcaa45993a3e: Implement EditFilterHookRunner.Apr 18 2015, 12:57 PM
Diffusion mentioned this in rMEXTb75ecf8774a6: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 18 2015, 12:57 PM
gerritbot added a comment.Apr 20 2015, 2:25 PM

Change 204790 merged by jenkins-bot:
Run EditFilterHooks in RedirectCreationInteractor

https://gerrit.wikimedia.org/r/204790

Addshore mentioned this in rMEXT8612b23b22c7: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 20 2015, 2:25 PM
Addshore mentioned this in rEWBA7883a4127b5f: Run EditFilterHooks in RedirectCreationInteractor.
hoo closed this task as Resolved.Apr 20 2015, 3:48 PM
hoo removed projects: Patch-For-Review, patch-welcome.
hoo moved this task from Review to Done on the Wikidata-Sprint-2015-04-07 board.Apr 20 2015, 3:52 PM
• Deskana moved this task from Backlog to Resolved/Invalid/Legacy/Declined on the AbuseFilter board.Apr 23 2015, 4:50 AM
matej_suchanek mentioned this in T98669: AbuseFilter on Wikidata fails on blocking IPs.May 9 2015, 12:33 PM
matej_suchanek mentioned this in T98372: AbuseFilter doesn't log removal of redirects.May 11 2015, 1:18 PM
Bugreporter removed a parent task: T76230: [Epic] data quality and trust.Jul 11 2022, 11:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits