Page MenuHomePhabricator

Plural messages with callback functions for external links no longer work
Closed, ResolvedPublic

Description

This is a regression introduced by https://gerrit.wikimedia.org/r/#/c/156237/5/resources/src/mediawiki/mediawiki.jqueryMsg.js,unified and specifically the .html() call on line 1139, which has the effect of flattening the link into its html code in the final rendered message.

The broken message is in UploadWizard: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/908

The affected message calls .msg() with these kinds of parameters: .msg( 'api-error-duplicate', [1, foo] ) where "foo" is a callback function, to be executed on click of the extLink.

To view this issue live, just deliberately re-upload an existing file with Upload Wizard.


Version: 1.24rc
Severity: normal

Details

Reference
bz71368

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:44 AM
bzimport set Reference to bz71368.
bzimport added a subscriber: Unknown Object (MLST).
  • This bug has been marked as a duplicate of bug 70617 ***