Page MenuHomePhabricator

False height of checkbox focus ::after
Closed, ResolvedPublic

Description

invalid negative height result in Google Chrome

Line https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki.ui/components/checkbox.less#L85
of checkbox.less results in a negative value after the change to em value for @checkboxSize (Ia6adc4bda000508f14acf4214e778118efa35be0) which isn't a valid value (see attachment for result in Chrome, same in FF).

@focusBottomBorderSize: 3px;
@checkboxSize: 1.6em;

height: @checkboxSize - @focusBottomBorderSize + 1; -> -0.4em


Version: 1.25-git
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=70133

Attached:

Details

Reference
bz71506

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:53 AM
bzimport set Reference to bz71506.
bzimport added a subscriber: Unknown Object (MLST).
Florian created this task.Oct 1 2014, 11:00 AM

P.S.: Can be reproduced on each wmf-wiki running 1.25wmf1 (testwiki, mediawiki, wikinews, wikisource, e.g.) on the login form, e.g.:
https://www.mediawiki.org/wiki/Special:UserLogin

Florian: As you marked this as blocking bug 38865, could you elaborate how severe the problem is, and which functionality this problem destroys from a user point of view?

(In reply to Andre Klapper from comment #2)

Florian: As you marked this as blocking bug 38865, could you elaborate how
severe the problem is, and which functionality this problem destroys from a
user point of view?

Ugh, that's a fault. I forgot to emove the bug before saving. It's a problem of 1.25wmf1, but there is no functionality broken, so no blocking :)

Change 164092 had a related patch set uploaded by Florianschmidtwelzow:
Use ems instead of pixels for checkbox

https://gerrit.wikimedia.org/r/164092

Change 164092 merged by jenkins-bot:
Use ems instead of pixels for checkbox

https://gerrit.wikimedia.org/r/164092