Page MenuHomePhabricator

VisualEditor: [Regression] Clicking the link tool or Ctrl+K keyboard command on an auto-numbered external link triggers the wrong (annotation) link inspector
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Open a page that already contains an external link without a label: [http://example.com].
  1. Try to change that link to [http://example.com anything]. No fair removing the whole link and re-adding it.

Results:

Yeah, I couldn't figure out how to do that either.

(According to the bug titles, bug 51309, bug 53505, and maybe some others address this, but the descriptions don't seem to match the titles very closely.)


Version: unspecified
Severity: enhancement

Details

Reference
bz72150

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:43 AM
bzimport set Reference to bz72150.

Add label
Change selection to select all except the last letter
type : anything
delete last letter

not ...

  1. Select link.
  2. Edit link.
  3. Click "Add label".

Done?

Created attachment 16793
Screenshot of link dialog

Attached:

Not done. There's no "Add label" button (see screenshot).

(In reply to WhatamIdoing from comment #4)

Not done. There's no "Add label" button (see screenshot).

How did you get the wrong link dialog to trigger? Link and reproduction steps please.

Steps to reproduce:

  1. 1. Open a page that already contains an external link without a label: [http://example.com], such as https://en.wikipedia.org/wiki/User:Whatamidoing_%28WMF%29/sandbox?veaction=edit (scroll down to the ==External links== section).
  1. Open the link dialog.

I get the 'wrong' dialog in both Safari 6.2 and Firefox 32 on en.wp, mw.org, and beta labs, so it's not just one version. Perhaps it's Mac specific? I've asked Phatom87 (Mozilla Firefox user) for browser and OS information.

I tried this earlier and works for me in Chrome/Win8 and Safari on my Air. (6.2 isn't the most recent Safari version, but I don't think that matters). Can it be some kind of cache issue?

(Also, works fine in both skins.)

Aha, the trick is you're using the toolbar button (or keyboard shortcut) rather than the context menu item.

This is a regression. It's loading the link annotation editor rather than the link node editor. Clicking the context menu works just fine. Boo.

Phatom87 says he's been using "the tab that shows up after clicking on the link." He's running Mozilla browser version is 32.0.3 and kde Linux 4.14.1.

gerritadmin wrote:

Change 168030 had a related patch set uploaded by Catrope:
Open the linkNode inspector when pressing Ctrl+K on a link node

https://gerrit.wikimedia.org/r/168030

gerritadmin wrote:

Change 168030 merged by jenkins-bot:
Open the linkNode inspector when pressing Ctrl+K on a link node

https://gerrit.wikimedia.org/r/168030