Page MenuHomePhabricator

Actually run MediaWiki-VisualEditor's tests for MWHeadingNode / MWPreformattedNode
Closed, ResolvedPublic8 Estimated Story Points


Right now we have a hack in ve.test.utils.js that reregisters the core versions of HeadingNode and PreformattedNode to ensure MWHeadingNode and MWPreformattedNode aren't used, because using them would break the VE core tests when run in VE-MW.

This is horrible, because it makes us unable to test specific behavior in the MW nodes. For instance, fails its own tests because those tests use HeadingNode rather than MWHeadingNode, even though the tests in question were clearly designed to use MWHeadingNode.

We should come up with a way that MW nodes can be not registered for code tests, but be registered for MW tests.

Version: unspecified
Severity: enhancement

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:59 AM
bzimport set Reference to bz72398.
gerritbot subscribed.

Change 191036 had a related patch set uploaded (by Esanders):
Add tests for MW node variants (heading/table/pre)


Change 191036 merged by jenkins-bot:
Add tests for MW node variants (heading/table/pre)

Jdforrester-WMF renamed this task from VisualEditor: Actually run tests for MWHeadingNode / MWPreformattedNode to Actually run MediaWiki-VisualEditor's tests for MWHeadingNode / MWPreformattedNode.Feb 17 2015, 6:51 PM
Jdforrester-WMF closed this task as Resolved.