Page MenuHomePhabricator

VisualEditor Mobile: The label for "Re-use" tool is not greyed out when the tool is disabled (icon is greyed out)
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with mobile VE which does not have any reference in it to re-use.

Observed Result:

The "Re-use" label for the button is not greyed out even if the button icon is

See the screenshot attached
Environment:Production,test2 and Betalabs


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz72405

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz72405.

Looks like this is caused by MobileFrontend's less/modules/editor/VisualEditorOverlay.less file - specifically this part:
.oo-ui-tool-title {

color: @grayDark;
font-size: .9em;

}
Which is taking precedence over the styles for the oo-ui-widget-disabled stuff.

What if we changed it to this?
.oo-ui-widget-enabled > .oo-ui-tool-title {

color: @grayDark;

}
.oo-ui-tool-title {

font-size: .9em;

}

(In reply to Alex Monk from comment #1)

Looks like this is caused by MobileFrontend's
less/modules/editor/VisualEditorOverlay.less file - specifically this part:
.oo-ui-tool-title {

color: @grayDark;
font-size: .9em;

}
Which is taking precedence over the styles for the oo-ui-widget-disabled
stuff.

What if we changed it to this?
.oo-ui-widget-enabled > .oo-ui-tool-title {

color: @grayDark;

}
.oo-ui-tool-title {

font-size: .9em;

}

Eurgh. Another reminder that we need to kill VisualEditorOverlay.less.

gerritadmin wrote:

Change 170790 had a related patch set uploaded by Alex Monk:
VE: Don't set @grayDark colour for tool titles in disabled widgets

https://gerrit.wikimedia.org/r/170790

gerritadmin wrote:

Change 170790 merged by jenkins-bot:
VE: Don't set @grayDark colour for tool titles in disabled widgets

https://gerrit.wikimedia.org/r/170790

Verified the fix in Betalabs

Verified the fix in test2

Verified the fix in production