Page MenuHomePhabricator

VisualEditor: [Regression wmf7] Deleted template parameters aren't actually deleted
Closed, ResolvedPublic

Description

When I click on the "Bin" icon to delete an empty parameter from a template, the system doesn't delete it.


Version: unspecified
Severity: major

Details

Reference
bz73134

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz73134.
Nnvu created this task.Nov 7 2014, 1:54 PM
Mvolz added a comment.Nov 7 2014, 2:03 PM

I'm unable to duplicate this on master. I tried emptying the field and then deleting it, which worked. I also tried adding an empty field in wikitext, saving, and then opening it up in VE. I was able to delete the parameter then too.

Do you have any more details that might help us duplicate? Do you have a particular diff where this was happening?

Nnvu added a comment.Nov 7 2014, 2:13 PM

I tried to delete the field on [https://it.wikipedia.org/wiki/Atletica_leggera_ai_Giochi_della_XXV_Olimpiade_-_100_metri_ostacoli this page] with Chrome and Firefox, but I couldn't delete any field.

In [https://it.wikipedia.org/w/index.php?title=Utente%3ANnvu%2FSandbox1&diff=69043230&oldid=69043213 this edit] I tried to delete the field "successivo" (which is not a required field) and I couldn't delete it.

Mvolz added a comment.Nov 7 2014, 2:25 PM

Ok, on both of those templates I was able to delete the missing fields while using Chrome on Ubuntu.

You could try opening up the javascript console in Chrome (Ctrl+Shift+J) and seeing if any errors appear when you try to use the bin button.

Nnvu added a comment.Nov 7 2014, 2:29 PM

I got no error.

Elitre added a comment.Nov 7 2014, 6:56 PM

Can confirm in Chrome and FF. What happens is that clicking on the bin makes the field disappear in the dialog, but when you save it's still in the template, as if you hadn't changed anything.

Did we break something when we re-wrote the template parameter fixing code last week?

gerritadmin wrote:

Change 172317 had a related patch set uploaded by Catrope:
Followup a054a75: don't reintroduce removed template parameters

https://gerrit.wikimedia.org/r/172317

gerritadmin wrote:

Change 172317 merged by jenkins-bot:
Followup a054a75: don't reintroduce removed template parameters

https://gerrit.wikimedia.org/r/172317

gerritadmin wrote:

Change 172446 had a related patch set uploaded by Catrope:
Followup a054a75: don't reintroduce removed template parameters

https://gerrit.wikimedia.org/r/172446

gerritadmin wrote:

Change 172446 merged by jenkins-bot:
Followup a054a75: don't reintroduce removed template parameters

https://gerrit.wikimedia.org/r/172446

Fix was backported to wmf7 and deployed.

Verified in Betalabs and test2.

Nnvu added a comment.Nov 13 2014, 8:23 AM

Confirmed, it works on itwiki (Chrome; VEctor; Win 8.1)

Verified in production.