Page MenuHomePhabricator
Create Task
Maniphest T75370

deletedrevs deprecated
Closed, ResolvedPublicBUG REPORT
Actions

Description

In MediaWiki 1.25 there was an API change announced:

list=deletedrevs becomes list=alldeletedrevisions
prop=deletedrevs becomes prop=deletedrevisions

http://git.wikimedia.org/blobdiff/mediawiki%2Fcore.git/991de897e4781597f60a9c19d84df740a2b68ed1/includes%2Fapi%2FApiQueryDeletedrevs.php

APISite.deletedrevs uses API deletedrevs. This should use list alldeletedrevisions or prop deletedrevisions on 1.25+ (See APISite.version). The version test could be more specific. i.e. if it was released in 1.25wmf7 (as announced, but may not be reality), that can be used as the version test.

pywikibot/data/api.py includes a TODO which can be removed when this is completed.

See also T74733: Implement site.undelete.

Details

Reference
bz73370
SubjectRepoBranchLines +/-
[bugfix] Implement deletedrevisions api callpywikibot/coremaster+182 -91
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:55 AM
• bzimport added a project: Pywikibot-General.
• bzimport set Reference to bz73370.
• bzimport added a subscriber: Unknown Object (????).
jayvdb created this task.Nov 13 2014, 3:00 PM
Aklapper added a project: Pywikibot.Nov 27 2014, 4:10 PM
jayvdb moved this task from Backlog to Wikimedia prod/Cloud Services issues on the Pywikibot board.Nov 30 2014, 12:43 PM
jayvdb moved this task from Backlog to Probably both (bugs only) on the Pywikibot-General board.Dec 6 2014, 2:44 AM
jayvdb mentioned this in T101810: Get deleted revisions by username.Jun 9 2015, 5:15 AM
jayvdb updated the task description. (Show Details)Dec 9 2015, 2:27 PM
jayvdb removed a project: Pywikibot-General.
jayvdb set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2015, 2:27 PM
jayvdb added a project: Google-Code-In-2015.Dec 9 2015, 2:34 PM

https://codein.withgoogle.com/dashboard/tasks/4859009144193024/

jayvdb moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 10 2015, 6:47 AM
Dufferzafar subscribed.Jan 8 2016, 9:43 AM
AndyTechGuy claimed this task.Jan 12 2016, 11:54 PM
AndyTechGuy subscribed.

I have claimed this task on the GCI website.

AndyTechGuy removed AndyTechGuy as the assignee of this task.Jan 13 2016, 8:28 PM
IoannisKydonis subscribed.Jan 17 2016, 2:58 PM
This comment was removed by IoannisKydonis.
IoannisKydonis claimed this task.Jan 17 2016, 3:00 PM

I have claimed this task on GCI.

IoannisKydonis added a comment.Jan 17 2016, 4:06 PM

How can i run a test?

jayvdb added a comment.Jan 17 2016, 8:48 PM

See the README in the tests/ directory

Xqt removed IoannisKydonis as the assignee of this task.Apr 24 2017, 1:52 PM
Xqt removed a project: Google-Code-In-2015.
• Pchelolo mentioned this in T198343: Replace all calls to Revision::getRevisionText().Sep 18 2019, 9:05 PM
Xqt raised the priority of this task from Low to High.Sep 19 2019, 4:12 AM
Xqt claimed this task.Sep 19 2019, 4:39 AM
gerritbot added a comment.Sep 19 2019, 12:29 PM

Change 538006 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Implement alldeletedrevisions api call

https://gerrit.wikimedia.org/r/538006

gerritbot added a project: Patch-For-Review.Sep 19 2019, 12:29 PM
Xqt added a subscriber: Anomie.Sep 19 2019, 12:31 PM
Anomie added a project: Platform Team Workboards (Clinic Duty Team).Sep 19 2019, 4:32 PM
Anomie moved this task from Inbox to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.
Anomie moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Sep 20 2019, 3:44 PM
Xqt added a comment.Sep 23 2019, 12:44 PM

The result of deletedrevs ListGenerator and deletedrevisions PropertyGenerator is different.

ListGenerator:

{'ns': 0,
 'revisions': [{'comment': 'Framawiki moved page [[Pywikibot bad token test]] '
                           'to [[User:Framawiki/pwb tests/bad token]]: move to '

                           'user namespace to avoid deletion for page '
                           'inactivity',
                'parentid': 0,
                'revid': 341153,
                'timestamp': '2017-12-29T15:09:29Z',
                'user': 'Framawiki'}],
 'title': 'Pywikibot bad token test'}

PropertyGenerator:

{'deletedrevisions': [{'comment': 'Framawiki moved page [[Pywikibot bad token '
                                  'test]] to [[User:Framawiki/pwb tests/bad '
                                  'token]]: move to user namespace to avoid '
                                  'deletion for page inactivity',
                       'parentid': 0,
                       'revid': 341153,
                       'timestamp': '2017-12-29T15:09:29Z',
                       'user': 'Framawiki'}],
 'ns': 0,
 'pageid': 81035,
 'title': 'Pywikibot bad token test'}
Xqt changed the subtype of this task from "Task" to "Bug Report".Sep 23 2019, 4:19 PM
Huji closed this task as Resolved.Sep 24 2019, 12:49 AM
Huji removed a project: Patch-For-Review.
gerritbot added a comment.Sep 24 2019, 12:50 AM

Change 538006 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Implement deletedrevisions api call

https://gerrit.wikimedia.org/r/538006

Xqt mentioned this in rPWBC54115af81335: [bugfix] Implement deletedrevisions api call.Sep 24 2019, 12:51 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits