Page MenuHomePhabricator
Create Task
Maniphest T76807

Search and replace has weird display in RTL wikis
Closed, ResolvedPublic
Actions

Description

Thanks for the new search and replace functionality!

Just an issue: with RTL content, the found text is not highlighted correctly. The green highlighting appears on the other side of the screen.

צילום_מסך_מ־2014-12-05_01:00:11.png (900×1 px, 105 KB)

Details

SubjectRepoBranchLines +/-
Fix find and replace highlights in RTLVisualEditor/VisualEditormaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Dec 4 2014, 11:04 PM
Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added a project: VisualEditor-ContentEditable.
Amire80 changed Security from none to None.
Amire80 added subscribers: Esanders, Mooeypoo.
Amire80 subscribed.
Esanders claimed this task.Dec 5 2014, 12:46 PM
gerritbot added a project: Patch-For-Review.Dec 5 2014, 12:50 PM

Change 177785 had a related patch set uploaded (by Esanders):
Fix find and replace highlights in RTL

https://gerrit.wikimedia.org/r/177785

Patch-For-Review

gerritbot added a comment.Dec 5 2014, 5:03 PM

Change 177785 merged by jenkins-bot:
Fix find and replace highlights in RTL

https://gerrit.wikimedia.org/r/177785

Jdforrester-WMF renamed this task from VisualEditor Search and replace has weird display in RTL wikis to Search and replace has weird display in RTL wikis.Dec 5 2014, 5:35 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added VisualEditor, VisualEditor-EditingTools, WMF-deploy-2014-12-10_(1.25wmf12), VisualEditor-InterfaceLanguage; removed VisualEditor-ContentEditable.
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Dec 5 2014, 6:33 PM
Jdforrester-WMF closed this task as Resolved.Dec 10 2014, 5:56 PM
Etonkovidova subscribed.Dec 10 2014, 7:29 PM

Verified in betalabs. Also, all newly added English labels displayed in the screenshot - 'Match case', 'Replace all', 'Replace' etc - are displayed now in Hebrew.

Jdforrester-WMF subscribed.Dec 10 2014, 7:31 PM
In T76807#838613, @Etonkovidova wrote:

Verified in betalabs. Also, all newly added English labels displayed in the screenshot - 'Match case', 'Replace all', 'Replace' etc - are displayed now in Hebrew.

Yay for translators. :-)

Jdforrester-WMF removed a project: Patch-For-Review.Dec 15 2014, 9:22 PM
Amire80 added a project: I18n.Jan 26 2015, 5:53 PM
Esanders mentioned this in rGVED8be322b11487: Fix find and replace highlights in RTL.Mar 3 2015, 7:37 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Aug 5 2015, 12:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL