Page MenuHomePhabricator
Create Task
Maniphest T77169

Fix "PHP Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Input (semicolon and minus sign, invalid javascript):

;
-

When parsing this, instead of throwing a "Parser error", the parser loses track somehow and emits:

Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968

https://github.com/wikimedia/mediawiki/blob/16e3524bcab07f4f391cc32347d8732d734b1058/includes/libs/jsminplus.php#L1968

					if (in_array($op, $this->assignOps) && $input[strlen($op)] == '=')

Variable dump from this location:

$op
    string '-' (length=1)

$input
    string '-' (length=1)

$match
    array (size=2)
      0 => string '-' (length=1)
      1 => string '-' (length=1)

See also:

Details

SubjectRepoBranchLines +/-
resourceloader: Ignore warnings in JSMinPlus parsermediawiki/coremaster+15 -6
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Dec 8 2014, 4:30 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MediaWiki-ResourceLoader, MediaWiki-Core-Team, JavaScript.
Krinkle changed Security from none to None.
Krinkle added subscribers: Krinkle, Catrope.
Krinkle updated the task description. (Show Details)Dec 8 2014, 5:38 PM
• Nikerabbit subscribed.Dec 9 2014, 8:44 AM
Umherirrender subscribed.Jan 3 2015, 2:46 PM

jsminplus.php is external lib

Seems to need an upstream bug report

Aklapper triaged this task as Lowest priority.Feb 16 2015, 11:10 AM
bd808 removed a project: MediaWiki-Core-Team.Apr 8 2015, 10:44 PM
Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board.Apr 28 2015, 5:26 PM
Krinkle moved this task from Backlog to Accepted Enhancement on the MediaWiki-ResourceLoader board.
Krinkle moved this task from Accepted Enhancement to Confirmed Problem on the MediaWiki-ResourceLoader board.Sep 18 2015, 9:13 PM
Umherirrender unsubscribed.Sep 29 2015, 3:19 PM
Krinkle edited projects, added Upstream; removed JavaScript.May 12 2017, 5:49 PM

I an still reproduce this:

> echo JSMinPlus::minify("; -");
PHP Notice:  Uninitialized string offset: 1 in /vagrant/mediawiki/includes/libs/jsminplus.php on line 1968
PHP Stack trace:
PHP   3. eval() /vagrant/mediawiki/maintenance/eval.php:78
PHP   4. JSMinPlus::minify() /vagrant/mediawiki/maintenance/eval.php(78) : eval()'d code:1
PHP   5. JSMinPlus->min() /vagrant/mediawiki/includes/libs/jsminplus.php:207
PHP   6. JSParser->parse() /vagrant/mediawiki/includes/libs/jsminplus.php:214
PHP   7. JSParser->Script() /vagrant/mediawiki/includes/libs/jsminplus.php:739
PHP   8. JSParser->Statements() /vagrant/mediawiki/includes/libs/jsminplus.php:748
PHP   9. JSTokenizer->isDone() /vagrant/mediawiki/includes/libs/jsminplus.php:774
PHP  10. JSTokenizer->peek() /vagrant/mediawiki/includes/libs/jsminplus.php:1778
PHP  11. JSTokenizer->get() /vagrant/mediawiki/includes/libs/jsminplus.php:1806
Krinkle moved this task from Confirmed Problem to External on the MediaWiki-ResourceLoader board.May 12 2017, 6:15 PM
Krinkle added a project: Wikimedia-production-error.Nov 1 2018, 7:57 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptNov 1 2018, 7:57 PM
Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Nov 1 2018, 7:57 PM
• Imarlier moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Nov 5 2018, 9:12 PM
Krinkle raised the priority of this task from Lowest to Low.Dec 11 2018, 6:52 PM
Krinkle removed a project: Upstream.

For the record, the upstream for this library is https://crisp.tweakblogs.net/blog/cat/716. We've successfully upstreamed patches before, although not since 2012. And it looks like it certainly isn't actively maintained, but if and when this is patched, we should at least send the author a note in case they're still looking after it for the benefit of other users.

Krinkle moved this task from External to Confirmed Problem on the MediaWiki-ResourceLoader board.Dec 11 2018, 6:53 PM
gerritbot subscribed.Feb 13 2019, 1:46 AM

Change 490266 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Ignore warnings in JSMinPlus parser

https://gerrit.wikimedia.org/r/490266

gerritbot added a project: Patch-For-Review.Feb 13 2019, 1:46 AM
Krinkle claimed this task.Feb 13 2019, 1:46 AM
Krinkle moved this task from Backlog: Maintenance, non-prioritized to Doing (old) on the Performance-Team board.
gerritbot added a comment.Feb 13 2019, 5:36 AM

Change 490266 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Ignore warnings in JSMinPlus parser

https://gerrit.wikimedia.org/r/490266

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.18; 2019-02-19).Feb 13 2019, 6:00 AM
Krinkle closed this task as Resolved.Feb 13 2019, 8:51 PM
Krinkle moved this task from Older to Resolved on the Wikimedia-production-error board.
Krinkle removed projects: MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits