Pressing Escape while a dialog is open closes the editor, should only close the dialog.
|oojs/ui : master||Kill the escape keydown event after handling a window close|
|mediawiki/extensions/VisualEditor : wmf/1.25wmf12||Check for stopped propagation before showing close dialog|
|VisualEditor/VisualEditor : wmf/1.25wmf12||Stop propagation of events after handling trigger keys|
|VisualEditor/VisualEditor : master||Stop propagation of events after handling trigger keys|
|mediawiki/extensions/VisualEditor : master||Check for stopped propagation before showing close dialog|
|mediawiki/extensions/VisualEditor : master||When Esc is pressed, don't close VE if a window is open|
- Mentioned In
- rGOJU6f028abd0d6a: Kill the escape keydown event after handling a window close
rGVED4597c9a99dad: Stop propagation of events after handling trigger keys
rEVEDa18d1f1e347a: Check for stopped propagation before showing close dialog
rEVED9459e4e240a6: Check for stopped propagation before showing close dialog
I can reproduce on Windows 7 x64 on every browser I tested: Opera 27, Firefox 34, IE 11.
Apparently also closing the editor in this way and then reopening it causes funny things like dialogs not opening at all anymore.
This is only reproducible if you make no changes. In that case Escape immediately closes the editor. But if you have made changes, it will launch a dialog asking you if want to keep your changes. But if you already have a dialog open (which right after pressing escape you do, even if it's in the process of closing, because it takes time for it to close), that will fail and it will look like nothing happened.