Page MenuHomePhabricator
Create Task
Maniphest T78709

New improved LivePreview incompatible with ProofreadPage's fancy forms for Index: namespace pages
Closed, ResolvedPublic
Actions

Description

New improved LivePreview is incompatible with ProofreadPage's fancy forms for Index: namespace pages. Nothing explodes, the preview just doesn't appear. It has allegedly worked before.

Examples:

Details

SubjectRepoBranchLines +/-
mediawiki.action.edit.preview: Disable if there is no #wpTextbox1mediawiki/coremaster+8 -3
mediawiki.action.edit.preview: Disable if there is no #wpTextbox1mediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Dec 16 2014, 9:51 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: ProofreadPage, MediaWiki-Page-editing.
matmarex changed Security from none to None.
matmarex added subscribers: matmarex, TheDJ.
matmarex added a subscriber: Quiddity.
matmarex added a project: JavaScript.Dec 21 2014, 5:19 PM
TheDJ added a comment.Jan 5 2015, 2:29 PM

Yeah, before we did a normal submit, so whatever form was there, it got submitted, rendered and then we replaced parts of the existing page, with the returned result...

As far as I know, there is no option to API render such an edit form created by Proofread, so we should just properly disable this in those situations.

Aklapper triaged this task as Medium priority.Feb 26 2015, 1:44 PM
gerritbot subscribed.Mar 19 2015, 9:47 PM

Change 198107 had a related patch set uploaded (by TheDJ):
Live preview: Disable if there is no wpTextbox1

https://gerrit.wikimedia.org/r/198107

gerritbot added a project: Patch-For-Review.Mar 19 2015, 9:47 PM
TheDJ claimed this task.Mar 20 2015, 7:16 AM
matmarex closed this task as Resolved.Mar 22 2015, 11:58 AM
matmarex removed a project: Patch-For-Review.
gerritbot added a comment.Mar 22 2015, 12:07 PM

Change 198107 merged by jenkins-bot:
mediawiki.action.edit.preview: Disable if there is no #wpTextbox1

https://gerrit.wikimedia.org/r/198107

Ricordisamoa subscribed.Mar 22 2015, 8:11 PM
matmarex mentioned this in rMWc890a2fdefaa: mediawiki.action.edit.preview: Disable if there is no #wpTextbox1.Mar 23 2015, 3:51 PM
TheDJ reopened this task as Open.Mar 26 2015, 10:09 PM

Reopen due to causing regression T94089

gerritbot added a comment.Mar 29 2015, 1:57 PM

Change 200477 had a related patch set uploaded (by Gerrit Patch Uploader):
mediawiki.action.edit.preview: Disable if there is no #wpTextbox1

https://gerrit.wikimedia.org/r/200477

gerritbot added a project: Patch-For-Review.Mar 29 2015, 1:57 PM
Fomafix subscribed.Mar 29 2015, 1:58 PM
gerritbot added a comment.Mar 29 2015, 3:26 PM

Change 200477 merged by jenkins-bot:
mediawiki.action.edit.preview: Disable if there is no #wpTextbox1

https://gerrit.wikimedia.org/r/200477

Fomafix mentioned this in rMWb8c6b41a5017: mediawiki.action.edit.preview: Disable if there is no #wpTextbox1.Mar 29 2015, 3:27 PM
TheDJ closed this task as Resolved.Mar 29 2015, 9:13 PM
TheDJ removed a project: Patch-For-Review.
GOIII moved this task from Backlog to Done: to deploy/check on the ProofreadPage board.Jun 12 2016, 4:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL